Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2909163003: Use standard-priority GL context for VrShellGl. (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
mthiesse, billorr
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use standard-priority GL context for VrShellGl. The high-priority GL context appears to be conflicting with GVR's internal high priority context for async reprojection, so we can't use that in other VR code. BUG=727800, 725684 Review-Url: https://codereview.chromium.org/2909163003 Cr-Commit-Position: refs/heads/master@{#475634} Committed: https://chromium.googlesource.com/chromium/src/+/01693c7c9e98c2a4f3809cb1b4d6ae7b97eab02f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
klausw
3 years, 6 months ago (2017-05-30 18:37:49 UTC) #2
billorr
lgtm
3 years, 6 months ago (2017-05-30 18:47:08 UTC) #4
mthiesse
lgtm
3 years, 6 months ago (2017-05-30 18:49:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909163003/1
3 years, 6 months ago (2017-05-30 18:50:08 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:59:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01693c7c9e98c2a4f3809cb1b4d6...

Powered by Google App Engine
This is Rietveld 408576698