Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2909013002: Clean up shared names. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/names.dart View 2 chunks +10 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
Some of these names will be used in future CLs.
3 years, 6 months ago (2017-05-29 10:29:34 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-05-29 10:41:18 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-05-29 14:04:56 UTC) #4
ahe
3 years, 6 months ago (2017-05-31 09:08:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29dac16eba61ebad3d2309aa9284bf946c2d867e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698