Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2906253004: Avoid using Invalid{Statement,Expression,Initializer}. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid using Invalid{Statement,Expression,Initializer}. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/8ea78cbc3feb9715f66fe360379b7a9ab602a38b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -49 lines) Patch
M pkg/compiler/lib/src/kernel/fasta_support.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 12 chunks +33 lines, -22 lines 1 comment Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 3 chunks +11 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 5 chunks +30 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-kernel.status View 3 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +13 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
https://codereview.chromium.org/2906253004/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right): https://codereview.chromium.org/2906253004/diff/1/pkg/front_end/lib/src/fasta/kernel/body_builder.dart#newcode1236 pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1236: if (accessor is TypeDeclarationBuilder || accessor is! FastaAccessor) { ...
3 years, 6 months ago (2017-05-29 13:14:47 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-05-29 14:04:24 UTC) #3
ahe
3 years, 6 months ago (2017-05-31 12:53:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ea78cbc3feb9715f66fe360379b7a9ab602a38b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698