Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2908123002: Remove accessor properties not used by Fasta. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -87 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 3 chunks +0 lines, -48 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 11 chunks +12 lines, -23 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
ahe
pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart is a modified copy of pkg/kernel/lib/frontend/accessors.dart. The former is used by Fasta, the latter ...
3 years, 6 months ago (2017-05-29 10:21:04 UTC) #2
Johnni Winther
lgtm
3 years, 6 months ago (2017-05-29 10:40:43 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-05-29 14:05:47 UTC) #4
ahe
3 years, 6 months ago (2017-05-30 11:08:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9497f5d3f87b84c9e76b1aff2ce1fff4870c1521 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698