Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2908993002: Adds translate infobar impression in the old Translate UI on Android (Closed)

Created:
3 years, 6 months ago by ramyasharma
Modified:
3 years, 6 months ago
Reviewers:
dominickn
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Adds translate infobar impression in the old Translate UI on Android This is added so that we can compare the impressions in old UI and the new one. BUG=720231 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2897233002 Cr-Original-Commit-Position: refs/heads/master@{#474961} Review-Url: https://codereview.chromium.org/2908993002 Cr-Commit-Position: refs/branch-heads/3112@{#13} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/07ebfcba02801742f0a4f892898d4c76d69cd219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java View 3 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dominickn
rs lgtm
3 years, 6 months ago (2017-05-29 05:54:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908993002/1
3 years, 6 months ago (2017-05-29 05:57:16 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 6 months ago (2017-05-29 05:57:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908993002/1
3 years, 6 months ago (2017-05-29 05:58:45 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 06:00:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/07ebfcba02801742f0a4f892898d...

Powered by Google App Engine
This is Rietveld 408576698