MIPS[64]: Implement insert.df and I8 instructions in simulator

MIPS[64]: Implement insert.df and I8 instructions in simulator

Add support for insert.df, andi.b, ori.b, nori.b, xori.b,
bmnzi.b, bmzi.b, bseli.b, shf.df MSA instructions in mips32
and mips64 simulator.

BUG=

Review-Url: https://codereview.chromium.org/2908753002
Cr-Commit-Position: refs/heads/master@{#45620}
Committed: https://chromium.googlesource.com/v8/v8/+/f87271ccd034d4fed723dd6723a9f7d7fa892daa

[dusan.simicic, 2017-05-26 10:56:34]

dusan.simicic@imgtec.com changed reviewers:
+ ilija.pavlovic@imgtec.com, ivica.bogosavljevic@imgtec.com,
miran.karic@imgtec.com

[dusan.simicic, 2017-05-26 10:56:34]

PTAL

[Ilija.Pavlovic1, 2017-05-29 07:31:20]

ilija.pavlovic@imgtec.com changed reviewers:
+ Ilija.Pavlovic@imgtec.com

[Ilija.Pavlovic1, 2017-05-29 07:31:22]

lgtm

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc
File src/mips/simulator-mips.cc (right):

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4266: int8_t i8 = instr_.MsaImm8Value() & 0xFFu;
Is this mask 0xFFu needed?

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4270: int8_t ws[16], wd[16];
Value 16 is used in all subsequent "case" statements. Can it be separately
defined as constant? (For example as WRLEN_8)

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4347: int16_t ws[8], wd[8];
Value 8 as constant WRLEN_16?

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4358: int32_t ws[4], wd[4];
Value 4 as constant WRLEN_32?

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips.cc:5890: enum MsaI8Opcode {
Should this be moved in constants-mips.h?

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips64.cc (right):

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips64.cc:6722: kANDI,
Move in constants-mips64.h?

[miran.karic, 2017-05-29 15:54:08]

miran.karic@imgtec.com changed reviewers:
+ Miran.Karic@imgtec.com
- Ilija.Pavlovic@imgtec.com

[miran.karic, 2017-05-29 15:54:08]

lgtm

[dusan.simicic, 2017-05-29 16:32:14]

dusan.simicic@imgtec.com changed reviewers:
- Miran.Karic@imgtec.com

[dusan.simicic, 2017-05-29 16:32:15]

PTAL

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc
File src/mips/simulator-mips.cc (right):

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4266: int8_t i8 = instr_.MsaImm8Value() & 0xFFu;
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Is this mask 0xFFu needed? 

Not needed, MsaImm8Value() method returns 8bit value. Fixed in PS2.

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4270: int8_t ws[16], wd[16];
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Value 16 is used in all subsequent "case" statements. Can it be separately
> defined as constant? (For example as WRLEN_8)

Done. Also added definition for msa_reg_t union.

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4347: int16_t ws[8], wd[8];
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Value 8 as constant WRLEN_16?

Done.

https://codereview.chromium.org/2908753002/diff/1/src/mips/simulator-mips.cc#...
src/mips/simulator-mips.cc:4358: int32_t ws[4], wd[4];
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Value 4 as constant WRLEN_32?

Done.

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips.cc (right):

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips.cc:5890: enum MsaI8Opcode {
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Should this be moved in constants-mips.h?

We already have similar constants in constants-mips.h, so I removed this in PS2.
Thanks.

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
File test/cctest/test-assembler-mips64.cc (right):

https://codereview.chromium.org/2908753002/diff/1/test/cctest/test-assembler-...
test/cctest/test-assembler-mips64.cc:6722: kANDI,
On 2017/05/29 07:31:21, Ilija.Pavlovic1 wrote:
> Move in constants-mips64.h?

Same as for mips32.

[Ilija.Pavlovic1, 2017-05-30 08:35:36]

ilija.pavlovic@imgtec.com changed reviewers:
+ Ilija.Pavlovic@imgtec.com

[Ilija.Pavlovic1, 2017-05-30 08:35:36]

lgtm

[dusan.simicic, 2017-05-31 08:27:44]

The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 08:27:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 08:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 08:56:17]

Dry run: This issue passed the CQ dry run.

[dusan.simicic, 2017-05-31 09:32:40]

The CQ bit was checked by dusan.simicic@imgtec.com

[dusan.simicic, 2017-05-31 09:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
Miran.Karic@imgtec.com
Link to the patchset: https://codereview.chromium.org/2908753002/#ps20001
(title: "Review comments, rebase")

[commit-bot: I haz the power, 2017-05-31 09:32:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 09:34:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496223160437570,
"parent_rev": "69aa868bb717af38c05449621365cb5d484692c6", "commit_rev":
"f87271ccd034d4fed723dd6723a9f7d7fa892daa"}

[commit-bot: I haz the power, 2017-05-31 09:34:52]

Description was changed from

==========
MIPS[64]: Implement insert.df and I8 instructions in simulator

Add support for insert.df, andi.b, ori.b, nori.b, xori.b,
bmnzi.b, bmzi.b, bseli.b, shf.df MSA instructions in mips32
and mips64 simulator.

BUG=
==========

to

==========
MIPS[64]: Implement insert.df and I8 instructions in simulator

Add support for insert.df, andi.b, ori.b, nori.b, xori.b,
bmnzi.b, bmzi.b, bseli.b, shf.df MSA instructions in mips32
and mips64 simulator.

BUG=

Review-Url: https://codereview.chromium.org/2908753002
Cr-Commit-Position: refs/heads/master@{#45620}
Committed:
https://chromium.googlesource.com/v8/v8/+/f87271ccd034d4fed723dd6723a9f7d7fa8...
==========

[commit-bot: I haz the power, 2017-05-31 09:34:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f87271ccd034d4fed723dd6723a9f7d7fa8...