Include terminated extensions while retrieving extension version.

Include terminated extensions while retrieving extension version.

If an extension is terminated at the time of update, we wouldn't
fetch (ExtensionRegistry::GetStoredVersion) its correct version
to dispatch runtime.onInstalled. Fix this by including
terminated extensions.

Add a unit_test.

BUG=724563
Test=chrome.runtime.onInstalled should send correct previousVersion
for an extension that was terminated during update.

Review-Url: https://codereview.chromium.org/2908513002
Cr-Commit-Position: refs/heads/master@{#475007}
Committed: https://chromium.googlesource.com/chromium/src/+/c290763a1b98e8c9815e87e326b13a314605bf98

[lazyboy, 2017-05-25 17:31:15]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 17:31:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 17:44:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:44:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lazyboy, 2017-05-25 18:59:59]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2017-05-25 19:17:39]

lgtm; thanks for adding this!

https://codereview.chromium.org/2908513002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_service_unittest.cc (right):

https://codereview.chromium.org/2908513002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_service_unittest.cc:4318:
TEST_F(ExtensionServiceTest, TerminatedExtensionStoredVersion) {
Could we actually move this to extension_registry_unittest?  There's nothing
that requires the extension service, and extension service unittests are already
a bit bloated (7000 line file)

[lazyboy, 2017-05-25 21:38:27]

https://codereview.chromium.org/2908513002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_registry_unittest.cc (right):

https://codereview.chromium.org/2908513002/diff/40001/extensions/browser/exte...
extensions/browser/extension_registry_unittest.cc:300:
EXPECT_TRUE(registry.RemoveEnabled(extension_id));
Moved the test to this file. However, is this the better way to simulate
extension terminated from ExtensionRegistry's perspective?

[Devlin, 2017-05-25 21:40:13]

https://codereview.chromium.org/2908513002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_registry_unittest.cc (right):

https://codereview.chromium.org/2908513002/diff/40001/extensions/browser/exte...
extensions/browser/extension_registry_unittest.cc:300:
EXPECT_TRUE(registry.RemoveEnabled(extension_id));
On 2017/05/25 21:38:27, lazyboy wrote:
> Moved the test to this file. However, is this the better way to simulate
> extension terminated from ExtensionRegistry's perspective?

Yep; this should be fine.

[lazyboy, 2017-05-25 21:45:22]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 21:45:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 23:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 23:35:23]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lazyboy, 2017-05-26 01:49:32]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2017-05-26 01:49:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2908513002/#ps60001
(title: "fix browsertest")

[commit-bot: I haz the power, 2017-05-26 01:50:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 05:38:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 05:38:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lazyboy, 2017-05-26 14:38:15]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2017-05-26 14:38:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 15:24:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495809495492230,
"parent_rev": "83b898248b21bd35c368e2a23b71322e67f74a8d", "commit_rev":
"c290763a1b98e8c9815e87e326b13a314605bf98"}

[commit-bot: I haz the power, 2017-05-26 15:24:44]

Description was changed from

==========
Include terminated extensions while retrieving extension version.

If an extension is terminated at the time of update, we wouldn't
fetch (ExtensionRegistry::GetStoredVersion) its correct version
to dispatch runtime.onInstalled. Fix this by including
terminated extensions.

Add a unit_test.

BUG=724563
Test=chrome.runtime.onInstalled should send correct previousVersion
for an extension that was terminated during update.
==========

to

==========
Include terminated extensions while retrieving extension version.

If an extension is terminated at the time of update, we wouldn't
fetch (ExtensionRegistry::GetStoredVersion) its correct version
to dispatch runtime.onInstalled. Fix this by including
terminated extensions.

Add a unit_test.

BUG=724563
Test=chrome.runtime.onInstalled should send correct previousVersion
for an extension that was terminated during update.

Review-Url: https://codereview.chromium.org/2908513002
Cr-Commit-Position: refs/heads/master@{#475007}
Committed:
https://chromium.googlesource.com/chromium/src/+/c290763a1b98e8c9815e87e326b1...
==========

[commit-bot: I haz the power, 2017-05-26 15:24:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c290763a1b98e8c9815e87e326b1...