Include terminated extensions while retrieving extension version.

chrome/browser/extensions/extension_service_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 4296 matching lines @@
   EXPECT_FALSE(registry()->GetExtensionById(
       good_crx, extensions::ExtensionRegistry::TERMINATED));
   EXPECT_TRUE(service()->GetExtensionById(good_crx, true));
 
   EXPECT_EQ(0u, registry()->enabled_extensions().size());
   EXPECT_EQ(1u, registry()->disabled_extensions().size());
   EXPECT_EQ(0u, registry()->terminated_extensions().size());
   EXPECT_EQ(0u, registry()->blacklisted_extensions().size());
 }
 
+// Regression test for https://crbug.com/724563.
+TEST_F(ExtensionServiceTest, TerminatedExtensionStoredVersion) {

[Devlin, 2017/05/25 19:17:39]

Could we actually move this to extension_registry_unittest?  There's nothing
that requires the extension service, and extension service unittests are already
a bit bloated (7000 line file)

+  InitializeEmptyExtensionService();
+  InstallCRX(data_dir().AppendASCII("good.crx"), INSTALL_NEW);
+  TerminateExtension(good_crx);
+  EXPECT_TRUE(registry()->GetExtensionById(
+      good_crx, extensions::ExtensionRegistry::TERMINATED));
+  base::Version version = registry()->GetStoredVersion(good_crx);
+  ASSERT_TRUE(version.IsValid());
+  EXPECT_EQ("1.0.0.0", version.GetString());
+}
+
 // Tests that with the kDisableExtensions flag, extensions are not loaded by
 // the ExtensionService...
 TEST_F(ExtensionServiceTest, PRE_DisableAllExtensions) {
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kDisableExtensions);
   InitializeGoodInstalledExtensionService();
   service()->Init();
   EXPECT_TRUE(registry()->GenerateInstalledExtensionsSet()->is_empty());
 }
 
@@ skipping 2632 matching lines @@
             shared_module->manifest()->type());
   EXPECT_TRUE(registry()->enabled_extensions().Contains(kExtensionId));
 
   // Reload the extension and wait for it to complete. This previously crashed
   // (see crbug.com/676815).
   service()->ReloadExtension(kExtensionId);
   content::RunAllBlockingPoolTasksUntilIdle();
   // The shared module should be enabled.
   EXPECT_TRUE(registry()->enabled_extensions().Contains(kExtensionId));
 }