Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2908463003: [Media Router] Don't show "Manage Cast Devices" in incognito mode. (Closed)

Created:
3 years, 7 months ago by imcheng
Modified:
3 years, 7 months ago
Reviewers:
mark a. foltz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Don't show "Manage Cast Devices" in incognito mode. The cast setup page does not work in incognito mode anyway. BUG=726551 Review-Url: https://codereview.chromium.org/2908463003 Cr-Commit-Position: refs/heads/master@{#475168} Committed: https://chromium.googlesource.com/chromium/src/+/0f97c95ec5e806e2fe5dc2a6c33ec8d1c5aba2e4

Patch Set 1 #

Patch Set 2 : Added unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/ui/toolbar/media_router_contextual_menu.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
imcheng
PTAL
3 years, 7 months ago (2017-05-26 17:44:52 UTC) #2
mark a. foltz
On 2017/05/26 at 17:44:52, imcheng wrote: > PTAL LGTM % adding a unit test Getting ...
3 years, 7 months ago (2017-05-26 17:50:35 UTC) #3
imcheng
Thanks. Added unit test.
3 years, 7 months ago (2017-05-26 21:50:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908463003/20001
3 years, 7 months ago (2017-05-26 22:41:44 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 22:47:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0f97c95ec5e806e2fe5dc2a6c33e...

Powered by Google App Engine
This is Rietveld 408576698