Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_contextual_menu.cc

Issue 2908463003: [Media Router] Don't show "Manage Cast Devices" in incognito mode. (Closed)
Patch Set: Added unit test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h" 5 #include "chrome/browser/ui/toolbar/media_router_contextual_menu.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/user_metrics.h" 10 #include "base/metrics/user_metrics.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 gfx::kChromeIconGrey))); 67 gfx::kChromeIconGrey)));
68 } else { 68 } else {
69 menu_model_.AddCheckItemWithStringId( 69 menu_model_.AddCheckItemWithStringId(
70 IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION, 70 IDC_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION,
71 IDS_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION); 71 IDS_MEDIA_ROUTER_ALWAYS_SHOW_TOOLBAR_ACTION);
72 } 72 }
73 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_SHOW_IN_TOOLBAR, 73 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_SHOW_IN_TOOLBAR,
74 GetChangeVisibilityTextId()); 74 GetChangeVisibilityTextId());
75 menu_model_.AddSeparator(ui::NORMAL_SEPARATOR); 75 menu_model_.AddSeparator(ui::NORMAL_SEPARATOR);
76 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS) 76 #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
77 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_MANAGE_DEVICES, 77 if (!browser_->profile()->IsOffTheRecord()) {
78 IDS_MEDIA_ROUTER_MANAGE_DEVICES); 78 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_MANAGE_DEVICES,
79 IDS_MEDIA_ROUTER_MANAGE_DEVICES);
80 }
79 #endif 81 #endif
80 menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE, 82 menu_model_.AddCheckItemWithStringId(IDC_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE,
81 IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE); 83 IDS_MEDIA_ROUTER_CLOUD_SERVICES_TOGGLE);
82 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REPORT_ISSUE, 84 menu_model_.AddItemWithStringId(IDC_MEDIA_ROUTER_REPORT_ISSUE,
83 IDS_MEDIA_ROUTER_REPORT_ISSUE); 85 IDS_MEDIA_ROUTER_REPORT_ISSUE);
84 } 86 }
85 87
86 MediaRouterContextualMenu::~MediaRouterContextualMenu() {} 88 MediaRouterContextualMenu::~MediaRouterContextualMenu() {}
87 89
88 bool MediaRouterContextualMenu::GetAlwaysShowActionPref() const { 90 bool MediaRouterContextualMenu::GetAlwaysShowActionPref() const {
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 std::string(url::kStandardSchemeSeparator) + 193 std::string(url::kStandardSchemeSeparator) +
192 media_router->media_route_provider_extension_id() + 194 media_router->media_route_provider_extension_id() +
193 "/feedback.html"); 195 "/feedback.html");
194 chrome::ShowSingletonTab(browser_, GURL(feedback_url)); 196 chrome::ShowSingletonTab(browser_, GURL(feedback_url));
195 } 197 }
196 198
197 int MediaRouterContextualMenu::GetChangeVisibilityTextId() { 199 int MediaRouterContextualMenu::GetChangeVisibilityTextId() {
198 return is_action_in_toolbar_ ? IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU 200 return is_action_in_toolbar_ ? IDS_EXTENSIONS_HIDE_BUTTON_IN_MENU
199 : IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR; 201 : IDS_EXTENSIONS_SHOW_BUTTON_IN_TOOLBAR;
200 } 202 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698