Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2908413002: Re-enable ProofVerifierChromium tests by generating a signature (Closed)

Created:
3 years, 6 months ago by Ryan Hamilton
Modified:
3 years, 6 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ProofVerifierChromium tests by generating a signature dyanmically instead of using the old (and now invalid) signature. BUG=718895 Review-Url: https://codereview.chromium.org/2908413002 Cr-Commit-Position: refs/heads/master@{#475646} Committed: https://chromium.googlesource.com/chromium/src/+/0af6d95f72025aae5c137b54acfcb9b700a66bda

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -73 lines) Patch
M net/quic/chromium/crypto/proof_verifier_chromium_test.cc View 1 23 chunks +75 lines, -73 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ryan Hamilton
3 years, 6 months ago (2017-05-30 17:29:58 UTC) #4
Zhongyi Shi
lgtm
3 years, 6 months ago (2017-05-30 18:47:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908413002/50001
3 years, 6 months ago (2017-05-30 18:48:24 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 20:13:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/0af6d95f72025aae5c137b54acfc...

Powered by Google App Engine
This is Rietveld 408576698