Re-enable ProofVerifierChromium tests by generating a signature

net/quic/chromium/crypto/proof_verifier_chromium_test.cc

Index: net/quic/chromium/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/chromium/crypto/proof_verifier_chromium_test.cc b/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
index 6174abbe54032b681145fa51dec1abe564938934..6c9efa6997c87994ec01eeb177f14a8df909f9f3 100644
--- a/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/chromium/crypto/proof_verifier_chromium_test.cc
@@ -4,6 +4,7 @@
 
 #include "net/quic/chromium/crypto/proof_verifier_chromium.h"
 
+#include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "net/base/net_errors.h"
 #include "net/cert/cert_status_flags.h"
@@ -15,6 +16,7 @@
 #include "net/cert/mock_cert_verifier.h"
 #include "net/cert/multi_log_ct_verifier.h"
 #include "net/http/transport_security_state.h"
+#include "net/quic/chromium/crypto/proof_source_chromium.h"
 #include "net/quic/core/crypto/proof_verifier.h"
 #include "net/test/cert_test_util.h"
 #include "net/test/ct_test_util.h"
@@ -85,6 +87,22 @@ class MockRequireCTDelegate : public TransportSecurityState::RequireCTDelegate {
                CTRequirementLevel(const std::string& host));
 };
 
+// Proof source callback which saves the signature into |signature|.
+class SignatureSaver : public ProofSource::Callback {
+ public:
+  explicit SignatureSaver(std::string* signature) : signature_(signature) {}
+  ~SignatureSaver() override {}
+
+  void Run(bool /*ok*/,
+           const QuicReferenceCountedPointer<ProofSource::Chain>& /*chain*/,
+           const QuicCryptoProof& proof,
+           std::unique_ptr<ProofSource::Details> /*details*/) override {
+    *signature_ = proof.signature;
+  }
+
+  std::string* signature_;
+};
+
 class DummyProofVerifierCallback : public ProofVerifierCallback {
  public:
   DummyProofVerifierCallback() {}
@@ -98,6 +116,8 @@ class DummyProofVerifierCallback : public ProofVerifierCallback {
 };
 
 const char kTestHostname[] = "test.example.com";
+const char kTestChloHash[] = "CHLO hash";
+const char kTestEmptySCT[] = "";
 const uint16_t kTestPort = 8443;
 const char kTestConfig[] = "server config bytes";
 const char kLogDescription[] = "somelog";
@@ -148,35 +168,16 @@ class ProofVerifierChromiumTest : public ::testing::Test {
   }
 
   std::string GetTestSignature() {
-    // Sample known answer test from ProofTest.VerifyRSAKnownAnswerTest.
-    // Generated by dumping the bytes of the |signature| output of
-    // ProofSource::GetProof().
-    static const unsigned char kTestSignature[] = {
-        0x31, 0xd5, 0xfb, 0x40, 0x30, 0x75, 0xd2, 0x7d, 0x61, 0xf9, 0xd7, 0x54,
-        0x30, 0x06, 0xaf, 0x54, 0x0d, 0xb0, 0x0a, 0xda, 0x63, 0xca, 0x7e, 0x9e,
-        0xce, 0xba, 0x10, 0x05, 0x1b, 0xa6, 0x7f, 0xef, 0x2b, 0xa3, 0xff, 0x3c,
-        0xbb, 0x9a, 0xe4, 0xbf, 0xb8, 0x0c, 0xc1, 0xbd, 0xed, 0xc2, 0x90, 0x68,
-        0xeb, 0x45, 0x48, 0xea, 0x3c, 0x95, 0xf8, 0xa2, 0xb9, 0xe7, 0x62, 0x29,
-        0x00, 0xc3, 0x18, 0xb4, 0x16, 0x6f, 0x5e, 0xb0, 0xc1, 0x26, 0xc0, 0x4b,
-        0x84, 0xf5, 0x97, 0xfc, 0x17, 0xf9, 0x1c, 0x43, 0xb8, 0xf2, 0x3f, 0x38,
-        0x32, 0xad, 0x36, 0x52, 0x2c, 0x26, 0x92, 0x7a, 0xea, 0x2c, 0xa2, 0xf4,
-        0x28, 0x2f, 0x19, 0x4d, 0x1f, 0x11, 0x46, 0x82, 0xd0, 0xc4, 0x86, 0x56,
-        0x5c, 0x97, 0x9e, 0xc6, 0x37, 0x8e, 0xaf, 0x9d, 0x69, 0xe9, 0x4f, 0x5a,
-        0x6d, 0x70, 0x75, 0xc7, 0x41, 0x95, 0x68, 0x53, 0x94, 0xca, 0x31, 0x63,
-        0x61, 0x9f, 0xb8, 0x8c, 0x3b, 0x75, 0x36, 0x8b, 0x69, 0xa2, 0x35, 0xc0,
-        0x4b, 0x77, 0x55, 0x08, 0xc2, 0xb4, 0x56, 0xd2, 0x81, 0xce, 0x9e, 0x25,
-        0xdb, 0x50, 0x74, 0xb3, 0x8a, 0xd9, 0x20, 0x42, 0x3f, 0x85, 0x2d, 0xaa,
-        0xfd, 0x66, 0xfa, 0xd6, 0x95, 0x55, 0x6b, 0x63, 0x63, 0x04, 0xf8, 0x6c,
-        0x3e, 0x08, 0x22, 0x39, 0xb9, 0x9a, 0xe0, 0xd7, 0x01, 0xff, 0xeb, 0x8a,
-        0xb9, 0xe2, 0x34, 0xa5, 0xa0, 0x51, 0xe9, 0xbe, 0x15, 0x12, 0xbf, 0xbe,
-        0x64, 0x3d, 0x3f, 0x98, 0xce, 0xc1, 0xa6, 0x33, 0x32, 0xd3, 0x5c, 0xa8,
-        0x39, 0x93, 0xdc, 0x1c, 0xb9, 0xab, 0x3c, 0x80, 0x62, 0xb3, 0x76, 0x21,
-        0xdf, 0x47, 0x1e, 0xa9, 0x0e, 0x5e, 0x8a, 0xbe, 0x66, 0x5b, 0x7c, 0x21,
-        0xfa, 0x78, 0x2d, 0xd1, 0x1d, 0x5c, 0x35, 0x8a, 0x34, 0xb2, 0x1a, 0xc2,
-        0xc4, 0x4b, 0x53, 0x54,
-    };
-    return std::string(reinterpret_cast<const char*>(kTestSignature),
-                       sizeof(kTestSignature));
+    ProofSourceChromium source;
+    source.Initialize(
+        GetTestCertsDirectory().AppendASCII("quic_test.example.com.crt"),
+        GetTestCertsDirectory().AppendASCII("quic_test.example.com.key.pkcs8"),
+        GetTestCertsDirectory().AppendASCII("quic_test.example.com.key.sct"));
+    std::string signature;
+    source.GetProof(QuicSocketAddress(), kTestHostname, kTestConfig,
+                    QUIC_VERSION_35, kTestChloHash, QuicTagVector(),
+                    base::MakeUnique<SignatureSaver>(&signature));
+    return signature;
   }
 
   void GetSCTTestCertificates(std::vector<std::string>* certs) {
@@ -224,7 +225,7 @@ class ProofVerifierChromiumTest : public ::testing::Test {
 
 // Tests that the ProofVerifier fails verification if certificate
 // verification fails.
-TEST_F(ProofVerifierChromiumTest, DISABLED_FailsIfCertFails) {
+TEST_F(ProofVerifierChromiumTest, FailsIfCertFails) {
   MockCertVerifier dummy_verifier;
   ProofVerifierChromium proof_verifier(&dummy_verifier, &ct_policy_enforcer_,
                                        &transport_security_state_,
@@ -233,18 +234,19 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_FailsIfCertFails) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
 }
 
 // Valid SCT, but invalid signature.
-TEST_F(ProofVerifierChromiumTest, DISABLED_ValidSCTList) {
+TEST_F(ProofVerifierChromiumTest, ValidSCTList) {
   // Use different certificates for SCT tests.
   ASSERT_NO_FATAL_FAILURE(GetSCTTestCertificates(&certs_));
 
   MockCertVerifier cert_verifier;
+
   ProofVerifierChromium proof_verifier(&cert_verifier, &ct_policy_enforcer_,
                                        &transport_security_state_,
                                        ct_verifier_.get());
@@ -252,15 +254,15 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_ValidSCTList) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_,
-      ct::GetSCTListForTesting(), "", verify_context_.get(), &error_details_,
-      &details_, std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, ct::GetSCTListForTesting(), kTestEmptySCT, verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
   CheckSCT(/*sct_expected_ok=*/true);
 }
 
 // Invalid SCT and signature.
-TEST_F(ProofVerifierChromiumTest, DISABLED_InvalidSCTList) {
+TEST_F(ProofVerifierChromiumTest, InvalidSCTList) {
   // Use different certificates for SCT tests.
   ASSERT_NO_FATAL_FAILURE(GetSCTTestCertificates(&certs_));
 
@@ -272,16 +274,16 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_InvalidSCTList) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_,
-      ct::GetSCTListWithInvalidSCT(), "", verify_context_.get(),
-      &error_details_, &details_, std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, ct::GetSCTListWithInvalidSCT(), kTestEmptySCT,
+      verify_context_.get(), &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
   CheckSCT(/*sct_expected_ok=*/false);
 }
 
 // Tests that the ProofVerifier doesn't verify certificates if the config
 // signature fails.
-TEST_F(ProofVerifierChromiumTest, DISABLED_FailsIfSignatureFails) {
+TEST_F(ProofVerifierChromiumTest, FailsIfSignatureFails) {
   FailsTestCertVerifier cert_verifier;
   ProofVerifierChromium proof_verifier(&cert_verifier, &ct_policy_enforcer_,
                                        &transport_security_state_,
@@ -290,15 +292,15 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_FailsIfSignatureFails) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      kTestConfig, verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, kTestConfig, verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
 }
 
 // Tests that the certificate policy enforcer is consulted for EV
 // and the certificate is allowed to be EV.
-TEST_F(ProofVerifierChromiumTest, DISABLED_PreservesEVIfAllowed) {
+TEST_F(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -320,9 +322,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PreservesEVIfAllowed) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_SUCCESS, status);
 
   ASSERT_TRUE(details_.get());
@@ -334,7 +336,7 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PreservesEVIfAllowed) {
 
 // Tests that the certificate policy enforcer is consulted for EV
 // and the certificate is not allowed to be EV.
-TEST_F(ProofVerifierChromiumTest, DISABLED_StripsEVIfNotAllowed) {
+TEST_F(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -356,9 +358,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_StripsEVIfNotAllowed) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_SUCCESS, status);
 
   ASSERT_TRUE(details_.get());
@@ -371,7 +373,7 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_StripsEVIfNotAllowed) {
 
 // Tests that the certificate policy enforcer is not consulted if
 // the certificate is not EV.
-TEST_F(ProofVerifierChromiumTest, DISABLED_IgnoresPolicyEnforcerIfNotEV) {
+TEST_F(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -391,9 +393,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_IgnoresPolicyEnforcerIfNotEV) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_SUCCESS, status);
 
   ASSERT_TRUE(details_.get());
@@ -411,7 +413,7 @@ HashValueVector MakeHashValueVector(uint8_t tag) {
 }
 
 // Test that PKP is enforced for certificates that chain up to known roots.
-TEST_F(ProofVerifierChromiumTest, DISABLED_PKPEnforced) {
+TEST_F(ProofVerifierChromiumTest, PKPEnforced) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -436,9 +438,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PKPEnforced) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
 
   ASSERT_TRUE(details_.get());
@@ -452,7 +454,7 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PKPEnforced) {
 
 // Test |pkp_bypassed| is set when PKP is bypassed due to a local
 // trust anchor
-TEST_F(ProofVerifierChromiumTest, DISABLED_PKPBypassFlagSet) {
+TEST_F(ProofVerifierChromiumTest, PKPBypassFlagSet) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -477,9 +479,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PKPBypassFlagSet) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_SUCCESS, status);
 
   ASSERT_TRUE(details_.get());
@@ -490,7 +492,7 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PKPBypassFlagSet) {
 
 // Test that when CT is required (in this case, by the delegate), the
 // absence of CT information is a socket error.
-TEST_F(ProofVerifierChromiumTest, DISABLED_CTIsRequired) {
+TEST_F(ProofVerifierChromiumTest, CTIsRequired) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -523,9 +525,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_CTIsRequired) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
 
   ASSERT_TRUE(details_.get());
@@ -536,7 +538,7 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_CTIsRequired) {
 }
 
 // Test that CT is considered even when HPKP fails.
-TEST_F(ProofVerifierChromiumTest, DISABLED_PKPAndCTBothTested) {
+TEST_F(ProofVerifierChromiumTest, PKPAndCTBothTested) {
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
@@ -575,9 +577,9 @@ TEST_F(ProofVerifierChromiumTest, DISABLED_PKPAndCTBothTested) {
   std::unique_ptr<DummyProofVerifierCallback> callback(
       new DummyProofVerifierCallback);
   QuicAsyncStatus status = proof_verifier.VerifyProof(
-      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, "", certs_, "",
-      GetTestSignature(), verify_context_.get(), &error_details_, &details_,
-      std::move(callback));
+      kTestHostname, kTestPort, kTestConfig, QUIC_VERSION_35, kTestChloHash,
+      certs_, kTestEmptySCT, GetTestSignature(), verify_context_.get(),
+      &error_details_, &details_, std::move(callback));
   ASSERT_EQ(QUIC_FAILURE, status);
 
   ASSERT_TRUE(details_.get());