Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2908333002: Make Image::image_observer_ WeakPersistent (Closed)

Created:
3 years, 6 months ago by hiroshige
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Make Image::image_observer_ WeakPersistent |image_observer_| was made UntracedMember during Oilpanization in [1], and this CL turns it WeakPersistent, to clear |image_observer_| when the corresponding ImageResourceContent is garbage collected while Image is still alive because the Image is referenced from other than ImageResourceContent. This CL also add null checks of GetImageObserver() to SVG-related code, because GetImageObserver() can be null since before. [1] https://codereview.chromium.org/1610883002 BUG=726220 Review-Url: https://codereview.chromium.org/2905833003 Cr-Original-Commit-Position: refs/heads/master@{#475116} Review-Url: https://codereview.chromium.org/2908333002 . Cr-Commit-Position: refs/branch-heads/3112@{#24} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/6c28cbc115d39a06d728f09c69bb7100f6aaec86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/svg/as-image/adopt-while-async-svg-load-is-in-progress-crash.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
3 years, 6 months ago (2017-05-30 08:19:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c28cbc115d39a06d728f09c69bb7100f6aaec86.

Powered by Google App Engine
This is Rietveld 408576698