Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1610883002: Oilpan: ImageObserver needs to be a GC mixin. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-platform-graphics_chromium.org, dshwang, fs, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, drott+blinkwatch_chromium.org, Justin Novosad, Rik, gavinp+loader_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, vmpstr+blinkwatch_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, loading-reviews+fetch_chromium.org, Nate Chapin, Stephen Chennney, tyoshino+watch_chromium.org, f(malita), danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: ImageObserver needs to be a GC mixin. R=haraken BUG= Committed: https://crrev.com/bd807b3a29d4021b98b8b3cafc06eeeae8789ded Cr-Commit-Position: refs/heads/master@{#374896}

Patch Set 1 #

Patch Set 2 : unit test compile fix #

Total comments: 2

Patch Set 3 : remove clearImage() use in dtor #

Patch Set 4 : keep an UntracedMember<> instead #

Patch Set 5 : move up null check #

Patch Set 6 : git cl try #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -35 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 3 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 2 3 4 5 1 chunk +16 lines, -12 lines 3 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 2 3 6 chunks +16 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageObserver.h View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 37 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610883002/1
4 years, 11 months ago (2016-01-20 21:48:36 UTC) #2
sof
please take a look. Going after this ASan crasher https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/5925/layout-test-results/svg/as-image/svg-as-image-object-fit-contain-crash-log.txt Assuming I'm not too tired ...
4 years, 11 months ago (2016-01-20 21:51:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610883002/20001
4 years, 11 months ago (2016-01-20 21:58:29 UTC) #6
haraken
https://codereview.chromium.org/1610883002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResource.cpp File third_party/WebKit/Source/core/fetch/ImageResource.cpp (right): https://codereview.chromium.org/1610883002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResource.cpp#newcode97 third_party/WebKit/Source/core/fetch/ImageResource.cpp:97: clearImage(); Can we remove this in oilpan?
4 years, 11 months ago (2016-01-20 23:24:28 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 00:00:52 UTC) #10
sof
https://codereview.chromium.org/1610883002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResource.cpp File third_party/WebKit/Source/core/fetch/ImageResource.cpp (right): https://codereview.chromium.org/1610883002/diff/20001/third_party/WebKit/Source/core/fetch/ImageResource.cpp#newcode97 third_party/WebKit/Source/core/fetch/ImageResource.cpp:97: clearImage(); On 2016/01/20 23:24:27, haraken wrote: > > Can ...
4 years, 11 months ago (2016-01-21 06:14:24 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610883002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610883002/40001
4 years, 11 months ago (2016-01-21 06:16:16 UTC) #13
sof
This is very much related to https://codereview.chromium.org/891263003 There might be a way to address it ...
4 years, 11 months ago (2016-01-21 07:25:36 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 07:30:43 UTC) #16
haraken
LGTM On 2016/01/21 07:25:36, sof wrote: > This is very much related to https://codereview.chromium.org/891263003 > ...
4 years, 11 months ago (2016-01-21 09:56:42 UTC) #17
sof
On 2016/01/21 09:56:42, haraken wrote: > LGTM > > On 2016/01/21 07:25:36, sof wrote: > ...
4 years, 11 months ago (2016-01-21 10:03:36 UTC) #18
sof
Time to return to this one & get it ready as some flaky crashers can ...
4 years, 10 months ago (2016-02-10 22:05:42 UTC) #20
sof
haraken@: good to go?
4 years, 10 months ago (2016-02-11 12:41:34 UTC) #21
haraken
https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp File third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp (right): https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp#newcode98 third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp:98: if (Heap::willObjectBeLazilySwept(m_image->imageObserver())) Can we avoid using Heap::willObjectBeLazilySwept by using ...
4 years, 10 months ago (2016-02-11 13:25:19 UTC) #22
sof
https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp File third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp (right): https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp#newcode98 third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp:98: if (Heap::willObjectBeLazilySwept(m_image->imageObserver())) On 2016/02/11 13:25:19, haraken wrote: > > ...
4 years, 10 months ago (2016-02-11 13:27:41 UTC) #23
haraken
https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp File third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp (right): https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp#newcode98 third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp:98: if (Heap::willObjectBeLazilySwept(m_image->imageObserver())) On 2016/02/11 13:27:41, sof wrote: > On ...
4 years, 10 months ago (2016-02-11 13:49:40 UTC) #24
sof
On 2016/02/11 13:49:40, haraken wrote: > https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp > File third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp > (right): > > https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp#newcode98 ...
4 years, 10 months ago (2016-02-11 13:51:43 UTC) #25
haraken
On 2016/02/11 13:51:43, sof wrote: > On 2016/02/11 13:49:40, haraken wrote: > > > https://codereview.chromium.org/1610883002/diff/100001/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp ...
4 years, 10 months ago (2016-02-11 13:55:01 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610883002/100001
4 years, 10 months ago (2016-02-11 14:39:26 UTC) #28
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-11 15:15:01 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610883002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610883002/100001
4 years, 10 months ago (2016-02-11 15:18:20 UTC) #33
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-11 15:25:54 UTC) #35
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:35 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bd807b3a29d4021b98b8b3cafc06eeeae8789ded
Cr-Commit-Position: refs/heads/master@{#374896}

Powered by Google App Engine
This is Rietveld 408576698