Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2908313002: Revert of gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync. (Closed)

Created:
3 years, 6 months ago by Alexandre Courbot
Modified:
3 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync. (patchset #5 id:80001 of https://codereview.chromium.org/2864483007/ ) Reason for revert: Breaks UI on peach_pit http://crbug.com/727462 Original issue's description: > gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync. > > This allows partial swaps to be enabled on Mali devices. > > BUG=705290 > TBR=dcheng@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2864483007 > Cr-Commit-Position: refs/heads/master@{#475250} > Committed: https://chromium.googlesource.com/chromium/src/+/d2d8cbbe67801309f69be3c5c941efccb6fcbf6c TBR=dcastagna@chromium.org,dnicoara@chromium.org,piman@chromium.org,dcheng@chromium.org,reveman@chromium.org,hajimehoshi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=705290 Review-Url: https://codereview.chromium.org/2908313002 Cr-Commit-Position: refs/heads/master@{#475455} Committed: https://chromium.googlesource.com/chromium/src/+/0b74898cc7b8d9fdfe31d7ee00a206380b498ec9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/exo/wayland/clients/client_base.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 1 chunk +13 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Alexandre Courbot
Created Revert of gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync.
3 years, 6 months ago (2017-05-30 05:54:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908313002/1
3 years, 6 months ago (2017-05-30 05:55:44 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-05-30 05:55:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908313002/1
3 years, 6 months ago (2017-05-30 06:00:54 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-05-30 06:00:55 UTC) #9
hajimehoshi
lgtm
3 years, 6 months ago (2017-05-30 06:04:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908313002/1
3 years, 6 months ago (2017-05-30 06:05:09 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 07:51:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b74898cc7b8d9fdfe31d7ee00a2...

Powered by Google App Engine
This is Rietveld 408576698