Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2864483007: gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync.

Created:
3 years, 7 months ago by reveman
Modified:
3 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Use ANDROID_native_fence_sync instead of ARM_implicit_external_sync. This allows partial swaps to be enabled on Mali devices. BUG=705290 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : EGL_KHR_fence_sync DCHECK #

Total comments: 2

Patch Set 4 : bump bug list version #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -42 lines) Patch
M cc/output/direct_renderer.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M components/exo/wayland/clients/client_base.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 1 2 3 4 5 6 7 1 chunk +0 lines, -13 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/ipc/common/gpu_command_buffer_traits_multi.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
reveman
3 years, 7 months ago (2017-05-04 21:59:19 UTC) #4
reveman
please take a look
3 years, 7 months ago (2017-05-22 20:00:14 UTC) #5
Daniele Castagna
LGTM. https://codereview.chromium.org/2864483007/diff/20001/components/exo/wayland/clients/client_base.cc File components/exo/wayland/clients/client_base.cc (right): https://codereview.chromium.org/2864483007/diff/20001/components/exo/wayland/clients/client_base.cc#newcode294 components/exo/wayland/clients/client_base.cc:294: egl_sync_type_ = EGL_SYNC_FENCE_KHR; Should we DCHECK this is ...
3 years, 7 months ago (2017-05-22 20:04:08 UTC) #6
reveman
+piman fyi, I'll wait to land this until the required cros driver side changes that ...
3 years, 7 months ago (2017-05-22 20:27:19 UTC) #8
reveman
+dnicoara for ui/ozone/platform/drm/gpu
3 years, 7 months ago (2017-05-22 20:29:21 UTC) #10
piman
lgtm
3 years, 7 months ago (2017-05-22 20:30:54 UTC) #11
Julien Isorce
https://codereview.chromium.org/2864483007/diff/40001/gpu/config/gpu_driver_bug_list.json File gpu/config/gpu_driver_bug_list.json (left): https://codereview.chromium.org/2864483007/diff/40001/gpu/config/gpu_driver_bug_list.json#oldcode846 gpu/config/gpu_driver_bug_list.json:846: }, Just in case, don't forget to bump "version" ...
3 years, 7 months ago (2017-05-23 13:17:27 UTC) #12
dnicoara
lgtm
3 years, 7 months ago (2017-05-23 14:41:22 UTC) #13
reveman
https://codereview.chromium.org/2864483007/diff/40001/gpu/config/gpu_driver_bug_list.json File gpu/config/gpu_driver_bug_list.json (left): https://codereview.chromium.org/2864483007/diff/40001/gpu/config/gpu_driver_bug_list.json#oldcode846 gpu/config/gpu_driver_bug_list.json:846: }, On 2017/05/23 at 13:17:26, Julien Isorce wrote: > ...
3 years, 7 months ago (2017-05-23 20:26:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864483007/60001
3 years, 6 months ago (2017-05-27 17:14:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/449540)
3 years, 6 months ago (2017-05-27 17:20:28 UTC) #19
reveman
+dcheng, TBR for removal of 1 line in gpu/ipc/common/gpu_command_buffer_traits_multi.h
3 years, 6 months ago (2017-05-27 20:21:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2864483007/80001
3 years, 6 months ago (2017-05-27 20:21:57 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/d2d8cbbe67801309f69be3c5c941efccb6fcbf6c
3 years, 6 months ago (2017-05-27 21:23:43 UTC) #28
dcheng
LGTM
3 years, 6 months ago (2017-05-30 03:24:36 UTC) #29
Alexandre Courbot
3 years, 6 months ago (2017-05-30 05:54:43 UTC) #30
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2908313002/ by acourbot@chromium.org.

The reason for reverting is: Breaks UI on peach_pit

http://crbug.com/727462.

Powered by Google App Engine
This is Rietveld 408576698