Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2908253003: Handle null literal in compile_from_dill (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 chunks +3 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/ssa/type_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 5 chunks +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 6 months ago (2017-05-30 14:36:37 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2908253003/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test.dart File tests/compiler/dart2js/kernel/compile_from_dill_test.dart (right): https://codereview.chromium.org/2908253003/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test.dart#newcode37 tests/compiler/dart2js/kernel/compile_from_dill_test.dart:37: return null; it's not empty! it's not empty! ...
3 years, 6 months ago (2017-05-30 22:45:56 UTC) #3
Johnni Winther
3 years, 6 months ago (2017-05-31 11:08:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34832f7a1b852d9634f410a0504ddf20494010de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698