Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2908253003: Handle null literal in compile_from_dill (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index e58fed426c7d0d80689d65f81c6863b0298b9c80..4ad537e99804816d4febbc52e310cf25cef51d59 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -1322,11 +1322,8 @@ class DartTypeConverter extends ir.DartTypeVisitor<DartType> {
@override
DartType visitInvalidType(ir.InvalidType node) {
- if (topLevel) {
- throw new UnimplementedError(
- "Outermost invalid types not currently supported");
- }
- // Nested invalid types are treated as `dynamic`.
+ // Root uses such a `o is Unresolved` and `o as Unresolved` must be special
+ // cased in the builder, nested invalid types are treated as `dynamic`.
return const DynamicType();
}
}
@@ -1435,6 +1432,7 @@ class KernelResolutionWorldBuilder extends KernelResolutionWorldBuilderBase {
: super(
elementMap.elementEnvironment,
elementMap.commonElements,
+ elementMap._constantEnvironment.constantSystem,
nativeBasicData,
nativeDataBuilder,
interceptorDataBuilder,

Powered by Google App Engine
This is Rietveld 408576698