pkg/compiler/lib/src/ssa/builder_kernel.dart - Issue 2908253003: Handle null literal in compile_from_dill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder_kernel.dart

Issue 2908253003: Handle null literal in compile_from_dill (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder_kernel.dart

diff --git a/pkg/compiler/lib/src/ssa/builder_kernel.dart b/pkg/compiler/lib/src/ssa/builder_kernel.dart

index b7d05ebf4b966ef5ff937bd28c50aba96799b212..75a71a9a056154629785839653b4eebac47ec2d3 100644

--- a/pkg/compiler/lib/src/ssa/builder_kernel.dart

+++ b/pkg/compiler/lib/src/ssa/builder_kernel.dart

@@ -831,7 +831,7 @@ class KernelSsaBuilder extends ir.Visitor with GraphBuilder {

assert(_targetFunction != null && _targetFunction is ir.FunctionNode);

returnStatement.expression.accept(this);

value = pop();

- DartType returnType = astAdapter.getFunctionReturnType(_targetFunction);

+ DartType returnType = _elementMap.getFunctionType(_targetFunction);

if (_targetFunction.asyncMarker == ir.AsyncMarker.Async) {

if (options.enableTypeAssertions &&

!isValidAsyncReturnType(returnType)) {