Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2908083002: Move LeftWordPosition/RightWordPosition() to SelectionModifierWord.cpp (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LeftWordPosition/RightWordPosition() to SelectionModifierWord.cpp This patch moves |LeftWordPosition()|, |RightWordPosition()| with related functions to "SelectionModifierWord.cpp" as a preparation of making |{Left,Right}WordPosition()| as file local function since these functions are used only in |SelectionModifier| class for improving code health. This patch also makes moved code C++11'ish, |0| to |nullptr|, adding |final|, etc. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2908083002 Cr-Commit-Position: refs/heads/master@{#475428} Committed: https://chromium.googlesource.com/chromium/src/+/98c9b996ae68f0973d595b094fc0d2dbefc886a3

Patch Set 1 : 2017-05-29T16:46:55 #

Patch Set 2 : 2017-05-29T16:51:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -393 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/core/editing/SelectionModifierWord.cpp View 1 1 chunk +434 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 5 chunks +15 lines, -393 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-05-29 09:44:09 UTC) #8
yoichio
lgtm
3 years, 6 months ago (2017-05-30 04:45:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2908083002/20001
3 years, 6 months ago (2017-05-30 05:04:49 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 05:09:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/98c9b996ae68f0973d595b094fc0...

Powered by Google App Engine
This is Rietveld 408576698