Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2908083002: Move LeftWordPosition/RightWordPosition() to SelectionModifierWord.cpp (Closed)
Patch Set: 2017-05-29T16:51:51 Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.h b/third_party/WebKit/Source/core/editing/VisibleUnits.h
index 004227379bcde5cf9e699ed2aec725266fd9fce4..60f1bb351a7a81626fe35fcb54a2ea94f8df9869 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.h
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.h
@@ -183,8 +183,12 @@ CORE_EXPORT VisiblePositionInFlatTree
EndOfWord(const VisiblePositionInFlatTree&, EWordSide = kRightWordIfOnBoundary);
VisiblePosition PreviousWordPosition(const VisiblePosition&);
VisiblePosition NextWordPosition(const VisiblePosition&);
+// TODO(yosin): We'll move |RightPositionOf()| as file location function
+// for |SelectionModifier| class.
VisiblePosition RightWordPosition(const VisiblePosition&,
bool skips_space_when_moving_right);
+// TODO(yosin): We'll move |LeftPositionOf()| as file location function
+// for |SelectionModifier| class.
VisiblePosition LeftWordPosition(const VisiblePosition&,
bool skips_space_when_moving_right);
@@ -346,6 +350,18 @@ CORE_EXPORT IntRect ComputeTextRect(const EphemeralRange&);
IntRect ComputeTextRect(const EphemeralRangeInFlatTree&);
FloatRect ComputeTextFloatRect(const EphemeralRange&);
+// Export below functions only for |SelectionModifier|.
+VisiblePosition HonorEditingBoundaryAtOrBefore(const VisiblePosition&,
+ const Position&);
+
+Position NextRootInlineBoxCandidatePosition(Node*,
+ const VisiblePosition&,
+ EditableType);
+
+Position PreviousRootInlineBoxCandidatePosition(Node*,
+ const VisiblePosition&,
+ EditableType);
+
} // namespace blink
#endif // VisibleUnits_h

Powered by Google App Engine
This is Rietveld 408576698