CSS Conic Gradients: do not support unitless 0 angles

CSS Conic Gradients: do not support unitless 0 angles

A recent spec change means that 0 is no longer supported as a valid value for angles.
https://github.com/w3c/csswg-drafts/issues/1162#issuecomment-293637767

Linear gradients, like CSS transform, are an exception and are explicitly specified
to support unitless 0, to avoid breaking existing pages:
https://drafts.csswg.org/css-images-3/#linear-gradients
https://drafts.csswg.org/css-transforms/#valdef-transform-rotate

Conic gradients, being a new feature that has not yet shipped in browsers, should
only support angles with explicit units.
https://drafts.csswg.org/css-images-4/#conic-gradients

We update the parsing of conic gradients to reject unitless 0 angles.


BUG=727195
Review-Url: https://codereview.chromium.org/2908053002
Cr-Commit-Position: refs/heads/master@{#475562}
Committed: https://chromium.googlesource.com/chromium/src/+/a3410f5c72de0fecf8772dbeeee95514e57c4cb0

[Eric Willigers, 2017-05-29 04:51:27]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-05-29 04:51:38]

ericwilligers@chromium.org changed reviewers:
+ fmalita@chromium.org

[commit-bot: I haz the power, 2017-05-29 04:51:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-29 06:20:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-29 06:20:36]

Dry run: This issue passed the CQ dry run.

[f(malita), 2017-05-30 13:40:42]

LGTM

[Eric Willigers, 2017-05-30 14:04:56]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-05-30 14:05:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 16:50:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496153096501830, "parent_rev":
"e373a531ac62344a5fe43c81e9511bc0df495c3d", "commit_rev":
"a3410f5c72de0fecf8772dbeeee95514e57c4cb0"}

[commit-bot: I haz the power, 2017-05-30 16:50:42]

Description was changed from

==========
CSS Conic Gradients: do not support unitless 0 angles

A recent spec change means that 0 is no longer supported as a valid value for
angles.
https://github.com/w3c/csswg-drafts/issues/1162#issuecomment-293637767

Linear gradients, like CSS transform, are an exception and are explicitly
specified
to support unitless 0, to avoid breaking existing pages:
https://drafts.csswg.org/css-images-3/#linear-gradients
https://drafts.csswg.org/css-transforms/#valdef-transform-rotate

Conic gradients, being a new feature that has not yet shipped in browsers,
should
only support angles with explicit units.
https://drafts.csswg.org/css-images-4/#conic-gradients

We update the parsing of conic gradients to reject unitless 0 angles.


BUG=727195
==========

to

==========
CSS Conic Gradients: do not support unitless 0 angles

A recent spec change means that 0 is no longer supported as a valid value for
angles.
https://github.com/w3c/csswg-drafts/issues/1162#issuecomment-293637767

Linear gradients, like CSS transform, are an exception and are explicitly
specified
to support unitless 0, to avoid breaking existing pages:
https://drafts.csswg.org/css-images-3/#linear-gradients
https://drafts.csswg.org/css-transforms/#valdef-transform-rotate

Conic gradients, being a new feature that has not yet shipped in browsers,
should
only support angles with explicit units.
https://drafts.csswg.org/css-images-4/#conic-gradients

We update the parsing of conic gradients to reject unitless 0 angles.


BUG=727195

Review-Url: https://codereview.chromium.org/2908053002
Cr-Commit-Position: refs/heads/master@{#475562}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3410f5c72de0fecf8772dbeeee9...
==========

[commit-bot: I haz the power, 2017-05-30 16:50:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3410f5c72de0fecf8772dbeeee9...