Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2908053002: CSS Conic Gradients: do not support unitless 0 angles (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/gradients/repeating-conic-gradient.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
index a934b157cfae31b48c58c93a2e2f0243cd0c6b0c..9a507a3893c44883644fdc262fdded61f0a5c292 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
@@ -978,7 +978,7 @@ static CSSPrimitiveValue* ConsumeGradientAngleOrPercent(
UnitlessQuirk) {
const CSSParserToken& token = range.Peek();
if (token.GetType() == kDimensionToken || token.GetType() == kNumberToken) {
- return ConsumeAngle(range, context, UseCounter::kUnitlessZeroAngleGradient);
+ return ConsumeAngle(range, context, WTF::Optional<UseCounter::Feature>());
}
if (token.GetType() == kPercentageToken)
return ConsumePercent(range, value_range);
@@ -1222,7 +1222,7 @@ static CSSValue* ConsumeConicGradient(CSSParserTokenRange& args,
const CSSPrimitiveValue* from_angle = nullptr;
if (ConsumeIdent<CSSValueFrom>(args)) {
if (!(from_angle = ConsumeAngle(args, context,
- UseCounter::kUnitlessZeroAngleGradient)))
+ WTF::Optional<UseCounter::Feature>())))
return nullptr;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/gradients/repeating-conic-gradient.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698