Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 290803003: Remove auto-setup table. (Closed)

Created:
6 years, 7 months ago by terry
Modified:
6 years, 7 months ago
Reviewers:
siva
CC:
reviews+dom_dartlang.org, siva, vsm, rmacnak
Visibility:
Public.

Description

Remove auto-setup table; replaced with extended attribute DartNoAutoScope used in IDL files. BUG= R=asiva@google.com Committed: https://src.chromium.org/viewvc/multivm/branches/1650/blink?view=rev&revision=174374

Patch Set 1 #

Patch Set 2 : Eliminated auto_scope table in python and added DartNoAutoScope extended attribute #

Patch Set 3 : merged #

Patch Set 4 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -263 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/dart/scripts/dart_attributes.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/dart/scripts/dart_methods.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/dart/scripts/dart_types.py View 1 1 chunk +0 lines, -135 lines 0 comments Download
M Source/core/dom/Document.idl View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.idl View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Node.idl View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/NodeList.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.idl View 1 4 chunks +107 lines, -107 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
terry
6 years, 7 months ago (2014-05-19 17:07:21 UTC) #1
siva
LGTM. Will the *.idl changes get up streamed or do we need to make these ...
6 years, 7 months ago (2014-05-19 17:26:19 UTC) #2
terry
6 years, 7 months ago (2014-05-20 12:43:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r174374 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698