[css-typed-om] add toMatrix() method in CSSTransformValue.idl

[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

BUG=545318
Review-Url: https://codereview.chromium.org/2907973002
Cr-Commit-Position: refs/heads/master@{#476841}
Committed: https://chromium.googlesource.com/chromium/src/+/b24e869c0085f7cb80020f073f731c43ae97eb17

[Hwanseung Lee, 2017-05-27 08:12:47]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 08:12:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-05-27 09:34:23]

Description was changed from

==========
add toMatrix()

BUG=
==========

to

==========
[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

Bug:545318
==========

[Hwanseung Lee, 2017-05-27 09:34:30]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 09:34:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-05-27 09:34:53]

Description was changed from

==========
[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

Bug:545318
==========

to

==========
[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

BUG=545318
==========

[commit-bot: I haz the power, 2017-05-27 11:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 11:28:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Hwanseung Lee, 2017-05-27 11:43:12]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 11:43:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-05-27 11:54:21]

hs1217.lee@samsung.com changed reviewers:
+ dominicc@chromium.org, meade@chromium.org

[Hwanseung Lee, 2017-05-27 11:54:22]

@meade
PTAL, thank you.

@dominicc
i divide multiplySelf() to two functions at DOMMatrix.
could you review DOMMatrix files?

[commit-bot: I haz the power, 2017-05-27 13:24:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 13:24:24]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-05-29 04:12:48]

cssom/ lgtm. Please wait for dom's review for DOMMatrix.

[Hwanseung Lee, 2017-06-01 12:16:52]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[Hwanseung Lee, 2017-06-01 12:16:53]

@zino
i divide multiplySelf() to two functions at DOMMatrix.
could you review DOMMatrix files? thank you.

[zino, 2017-06-02 02:31:22]

https://codereview.chromium.org/2907973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp (right):

https://codereview.chromium.org/2907973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp:41: DOMMatrix*
matrix = DOMMatrix::fromMatrix(init, ASSERT_NO_EXCEPTION);
IMHO, we don't need to copy the matrix from DOMMatrixInit.
So, please use DOMMatrix::Create() function (If not exists, please define it and
then use it.)

[Hwanseung Lee, 2017-06-02 11:12:33]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 11:12:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 13:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 13:12:02]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Hwanseung Lee, 2017-06-02 13:25:06]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 13:25:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-06-02 13:25:51]

@zino
PTAL, i add DOMMatrix::Create() function.

https://codereview.chromium.org/2907973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp (right):

https://codereview.chromium.org/2907973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp:41: DOMMatrix*
matrix = DOMMatrix::fromMatrix(init, ASSERT_NO_EXCEPTION);
On 2017/06/02 02:31:21, zino wrote:
> IMHO, we don't need to copy the matrix from DOMMatrixInit.
> So, please use DOMMatrix::Create() function (If not exists, please define it
and
> then use it.)

Done.

[commit-bot: I haz the power, 2017-06-02 14:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 14:35:02]

Dry run: This issue passed the CQ dry run.

[zino, 2017-06-02 15:50:08]

lgtm

[Hwanseung Lee, 2017-06-03 00:17:09]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-06-03 00:17:11]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2907973002/#ps60001
(title: "make Create() function in DOMMatrix")

[commit-bot: I haz the power, 2017-06-03 00:17:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 00:23:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496449029975040,
"parent_rev": "1f18863cc9b2a5fe463671f3eb60de2f95bbf283", "commit_rev":
"b24e869c0085f7cb80020f073f731c43ae97eb17"}

[commit-bot: I haz the power, 2017-06-03 00:23:26]

Description was changed from

==========
[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

BUG=545318
==========

to

==========
[css-typed-om] add toMatrix() method in CSSTransformValue.idl

The toMatrix() method of a CSSTransformValue this must, 
when called, perform the following steps:
1.Let matrix be a 4x4 matrix, initially set to the identity matrix.
2.For each func in this’s values to iterate over, 
 set matrix to the result of multiplying matrix 
 and func’s equivalent 4x4 transform matrix.
3.Return a new DOMMatrix representing matrix.

https://drafts.css-houdini.org/css-typed-om-1/#dom-csstransformvalue-tomatrix

BUG=545318

Review-Url: https://codereview.chromium.org/2907973002
Cr-Commit-Position: refs/heads/master@{#476841}
Committed:
https://chromium.googlesource.com/chromium/src/+/b24e869c0085f7cb80020f073f73...
==========

[commit-bot: I haz the power, 2017-06-03 00:23:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b24e869c0085f7cb80020f073f73...