Views/Harmony Remove references to ui/views/layout/layout_constants.h

Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
Review-Url: https://codereview.chromium.org/2907933002
Cr-Commit-Position: refs/heads/master@{#476081}
Committed: https://chromium.googlesource.com/chromium/src/+/cb36afa5925c2971e27b9653802a74264d76fa2b

[ananta, 2017-05-27 00:14:14]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-05-27 00:15:02]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-27 00:15:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 00:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 00:23:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ananta, 2017-05-27 01:18:55]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-05-27 01:19:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 01:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-27 01:19:13]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Peter Kasting, 2017-05-31 01:42:32]

LGTM with comments

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:48:
dialog_insets.right(),
These args should be the horizontal and vertical padding, rather than the left
and right.

This is a case where, for now, the right thing to do is to go ahead and use the
underlying distance metrics rather than pieces of the insets -- but there's a
bug open against kylixrd to let us just pass the Insets directly here.

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
(right):

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc:59:
dialog_insets.right(),
Same comment

[ananta, 2017-05-31 21:44:43]

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
(right):

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc:48:
dialog_insets.right(),
On 2017/05/31 01:42:32, Peter Kasting wrote:
> These args should be the horizontal and vertical padding, rather than the left
> and right.
> 
> This is a case where, for now, the right thing to do is to go ahead and use
the
> underlying distance metrics rather than pieces of the insets -- but there's a
> bug open against kylixrd to let us just pass the Insets directly here.

Thanks done

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc
(right):

https://codereview.chromium.org/2907933002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/apps/app_info_dialog/app_info_header_panel.cc:59:
dialog_insets.right(),
On 2017/05/31 01:42:32, Peter Kasting wrote:
> Same comment

Thanks done

[ananta, 2017-05-31 21:44:47]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-05-31 21:44:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2907933002/#ps40001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-05-31 21:45:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:05:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ananta, 2017-05-31 22:07:31]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-05-31 22:07:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2907933002/#ps60001
(title: "Remove unused dialog_insets")

[commit-bot: I haz the power, 2017-05-31 22:08:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:13:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496268451225220,
"parent_rev": "6467c368ef17eae06b31e4bc99672c2514965feb", "commit_rev":
"cb36afa5925c2971e27b9653802a74264d76fa2b"}

[commit-bot: I haz the power, 2017-05-31 23:13:14]

Description was changed from

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Views/Harmony Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2907933002
Cr-Commit-Position: refs/heads/master@{#476081}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb36afa5925c2971e27b9653802a...
==========

[commit-bot: I haz the power, 2017-05-31 23:13:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cb36afa5925c2971e27b9653802a...