Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc

Issue 2907933002: Views/Harmony Remove references to ui/views/layout/layout_constants.h (Closed)
Patch Set: Remove unused dialog_insets Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
index 4af7c7783d29d0a07f63cfff2da20e3a62893c52..908cf5dbaa9aab7754ecd5e224811f811e2c945b 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/extensions/extension_util.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/grit/generated_resources.h"
#include "extensions/browser/extension_prefs.h"
@@ -33,7 +34,6 @@
#include "ui/views/controls/label.h"
#include "ui/views/controls/link.h"
#include "ui/views/layout/box_layout.h"
-#include "ui/views/layout/layout_constants.h"
#include "ui/views/view.h"
// A model for a combobox selecting the launch options for a hosted app.
@@ -139,10 +139,10 @@ AppInfoSummaryPanel::AppInfoSummaryPanel(Profile* profile,
licenses_link_(NULL),
launch_options_combobox_(NULL),
weak_ptr_factory_(this) {
- SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical,
- 0,
- 0,
- views::kRelatedControlVerticalSpacing));
+ SetLayoutManager(
+ new views::BoxLayout(views::BoxLayout::kVertical, 0, 0,
+ ChromeLayoutProvider::Get()->GetDistanceMetric(
+ views::DISTANCE_RELATED_CONTROL_VERTICAL)));
AddSubviews();
}
@@ -156,10 +156,9 @@ void AppInfoSummaryPanel::AddDescriptionAndLinksControl(
views::View* vertical_stack) {
views::View* description_and_labels_stack = new views::View();
description_and_labels_stack->SetLayoutManager(
- new views::BoxLayout(views::BoxLayout::kVertical,
- 0,
- 0,
- views::kRelatedControlSmallVerticalSpacing));
+ new views::BoxLayout(views::BoxLayout::kVertical, 0, 0,
+ ChromeLayoutProvider::Get()->GetDistanceMetric(
+ DISTANCE_RELATED_CONTROL_VERTICAL_SMALL)));
if (!app_->description().empty()) {
// TODO(sashab): Clip the app's description to 4 lines, and use Label's
@@ -202,7 +201,8 @@ void AppInfoSummaryPanel::AddDetailsControl(views::View* vertical_stack) {
return;
views::View* details_list =
- CreateVerticalStack(views::kRelatedControlSmallVerticalSpacing);
+ CreateVerticalStack(ChromeLayoutProvider::Get()->GetDistanceMetric(
+ DISTANCE_RELATED_CONTROL_VERTICAL_SMALL));
// Add the size.
views::Label* size_title = new views::Label(
@@ -252,7 +252,8 @@ void AppInfoSummaryPanel::AddSubviews() {
l10n_util::GetStringUTF16(IDS_APPLICATION_INFO_APP_OVERVIEW_TITLE)));
views::View* vertical_stack =
- CreateVerticalStack(views::kUnrelatedControlVerticalSpacing);
+ CreateVerticalStack(ChromeLayoutProvider::Get()->GetDistanceMetric(
+ DISTANCE_UNRELATED_CONTROL_VERTICAL));
AddChildView(vertical_stack);
AddDescriptionAndLinksControl(vertical_stack);

Powered by Google App Engine
This is Rietveld 408576698