Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2907723002: [i18n] device-log to $i18n{} (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] device-log to $i18n{} This CL removes the i18n-content and i18n-values, replacing them with $i18n{}. BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2907723002 Cr-Commit-Position: refs/heads/master@{#475091} Committed: https://chromium.googlesource.com/chromium/src/+/6c6d330b4952c018fd8a59df156bc3dba612a1dc

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/browser/resources/device_log_ui/device_log_ui.html View 1 chunk +18 lines, -19 lines 4 comments Download

Messages

Total messages: 14 (9 generated)
dschuyler
3 years, 7 months ago (2017-05-26 00:30:53 UTC) #5
tommycli
lgtm https://codereview.chromium.org/2907723002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.html File chrome/browser/resources/device_log_ui/device_log_ui.html (right): https://codereview.chromium.org/2907723002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.html#newcode12 chrome/browser/resources/device_log_ui/device_log_ui.html:12: <body style="fontFamily:$i18n{fontfamily};fontSize:$i18n{fontsize};"> Kind of gross but I can ...
3 years, 7 months ago (2017-05-26 16:58:11 UTC) #8
dschuyler
https://codereview.chromium.org/2907723002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.html File chrome/browser/resources/device_log_ui/device_log_ui.html (right): https://codereview.chromium.org/2907723002/diff/1/chrome/browser/resources/device_log_ui/device_log_ui.html#newcode12 chrome/browser/resources/device_log_ui/device_log_ui.html:12: <body style="fontFamily:$i18n{fontfamily};fontSize:$i18n{fontsize};"> On 2017/05/26 16:58:10, tommycli wrote: > Kind ...
3 years, 7 months ago (2017-05-26 18:57:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907723002/1
3 years, 7 months ago (2017-05-26 18:57:47 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 19:51:12 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c6d330b4952c018fd8a59df156b...

Powered by Google App Engine
This is Rietveld 408576698