Chromium Code Reviews Chromium Code Reviews
Issue 2907723002:
[i18n] device-log to $i18n{} (Closed)
| Index: chrome/browser/resources/device_log_ui/device_log_ui.html |
| diff --git a/chrome/browser/resources/device_log_ui/device_log_ui.html b/chrome/browser/resources/device_log_ui/device_log_ui.html |
| index 17635afc445c5af5c924adc84666a97fe9c28601..30a10731589837c87fbdbd1689157bb6d31abbb8 100644 |
| --- a/chrome/browser/resources/device_log_ui/device_log_ui.html |
| +++ b/chrome/browser/resources/device_log_ui/device_log_ui.html |
| @@ -1,69 +1,68 @@ |
| <!DOCTYPE html> |
| -<html i18n-values="dir:textdirection;lang:language"> |
| +<html dir="$i18n{textdirection}" lang="$i18n{language}"> |
| <head> |
| <meta charset="utf-8"> |
| - <title id="device-log-title" i18n-content="titleText"></title> |
| + <title id="device-log-title">$i18n{titleText}</title> |
| <link rel="stylesheet" href="chrome://device-log/device_log_ui.css"> |
| <script src="chrome://resources/js/load_time_data.js"></script> |
| <script src="chrome://resources/js/util.js"></script> |
| <script src="chrome://device-log/strings.js"></script> |
| <script src="chrome://device-log/device_log_ui.js"></script> |
| </head> |
| -<body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> |
| +<body style="fontFamily:$i18n{fontfamily};fontSize:$i18n{fontsize};"> |
|
tommycli
2017/05/26 16:58:10
Kind of gross but I can see you're just transcribi
dschuyler
2017/05/26 18:57:01
Acknowledged.
|
| <div id="header"> |
| - <p i18n-content="autoRefreshText"></p> |
| + <p>$i18n{autoRefreshText}</p> |
| </div> |
| <div id="log-checkbox-container"> |
| - <button id="log-refresh" i18n-content="logRefreshText"></button> |
| - <label id="log-checkbox-show" i18n-content="logLevelShowText"></label> |
| - |
| + <button id="log-refresh">$i18n{logRefreshText}</button> |
| + <label id="log-checkbox-show">$i18n{logLevelShowText}</label> |
| <label> |
| <input id="log-level-error" type="checkbox"> |
| - <span i18n-content="logLevelErrorText"></span> |
| + <span>$i18n{logLevelErrorText}</span> |
|
tommycli
2017/05/26 16:58:10
I wonder if all these spans are no longer needed..
dschuyler
2017/05/26 18:57:01
Acknowledged.
|
| </label> |
| <label> |
| <input id="log-level-user" type="checkbox"> |
| - <span i18n-content="logLevelUserText"></span> |
| + <span>$i18n{logLevelUserText}</span> |
| </label> |
| <label> |
| <input id="log-level-event" type="checkbox"> |
| - <span i18n-content="logLevelEventText"></span> |
| + <span>$i18n{logLevelEventText}</span> |
| </label> |
| <label> |
| <input id="log-level-debug" type="checkbox"> |
| - <span i18n-content="logLevelDebugText"></span> |
| + <span>$i18n{logLevelDebugText}</span> |
| </label> |
| <label> |
| <input id="log-type-login" type="checkbox"> |
| - <span i18n-content="logTypeLoginText"></span> |
| + <span>$i18n{logTypeLoginText}</span> |
| </label> |
| <label> |
| <input id="log-type-network" type="checkbox"> |
| - <span i18n-content="logTypeNetworkText"></span> |
| + <span>$i18n{logTypeNetworkText}</span> |
| </label> |
| <label> |
| <input id="log-type-power" type="checkbox"> |
| - <span i18n-content="logTypePowerText"></span> |
| + <span>$i18n{logTypePowerText}</span> |
| </label> |
| <label> |
| <input id="log-type-bluetooth" type="checkbox"> |
| - <span i18n-content="logTypeBluetoothText"></span> |
| + <span>$i18n{logTypeBluetoothText}</span> |
| </label> |
| <label> |
| <input id="log-type-usb" type="checkbox"> |
| - <span i18n-content="logTypeUsbText"></span> |
| + <span>$i18n{logTypeUsbText}</span> |
| </label> |
| <label> |
| <input id="log-type-hid" type="checkbox"> |
| - <span i18n-content="logTypeHidText"></span> |
| + <span>$i18n{logTypeHidText}</span> |
| </label> |
| <label> |
| <input id="log-fileinfo" type="checkbox"> |
| - <span i18n-content="logLevelFileinfoText"></span> |
| + <span>$i18n{logLevelFileinfoText}</span> |
| </label> |
| <label> |
| <input id="log-timedetail" type="checkbox"> |
| - <span i18n-content="logLevelTimeDetailText"></span> |
| + <span>$i18n{logLevelTimeDetailText}</span> |
| </label> |
| </div> |
| <div id="log-container"></div> |
