Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2907713002: Move RareNonInheritedData::*DataEquivalent to ComputedStyle. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 31179c9743957a846bcfecb507ca08bcf6e5d8a6..f523dfdcb1983bd71dfc48420163bbd67c4fa78c 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -829,12 +829,8 @@ bool ComputedStyle::DiffNeedsPaintInvalidationObject(
other.rare_non_inherited_data_->object_fit_ ||
rare_non_inherited_data_->object_position_ !=
other.rare_non_inherited_data_->object_position_ ||
- !rare_non_inherited_data_->ShadowDataEquivalent(
- *other.rare_non_inherited_data_.Get()) ||
- !rare_non_inherited_data_->ShapeOutsideDataEquivalent(
- *other.rare_non_inherited_data_.Get()) ||
- !rare_non_inherited_data_->ClipPathDataEquivalent(
- *other.rare_non_inherited_data_.Get()) ||
+ !BoxShadowDataEquivalent(other) || !ShapeOutsideDataEquivalent(other) ||
+ !ClipPathDataEquivalent(other) ||
!rare_non_inherited_data_->outline_.VisuallyEqual(
other.rare_non_inherited_data_->outline_) ||
(VisitedLinkBorderLeftColor() != other.VisitedLinkBorderLeftColor() &&
@@ -942,14 +938,12 @@ void ComputedStyle::UpdatePropertySpecificDifferences(
if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
if ((rare_non_inherited_data_->filter_ !=
other.rare_non_inherited_data_->filter_) ||
- !rare_non_inherited_data_->ReflectionDataEquivalent(
- *other.rare_non_inherited_data_.Get()))
+ !ReflectionDataEquivalent(other))
diff.SetFilterChanged();
}
if (rare_non_inherited_data_.Get() != other.rare_non_inherited_data_.Get()) {
- if (!rare_non_inherited_data_->ShadowDataEquivalent(
- *other.rare_non_inherited_data_.Get()) ||
+ if (!BoxShadowDataEquivalent(other) ||
!rare_non_inherited_data_->outline_.VisuallyEqual(
other.rare_non_inherited_data_->outline_))
diff.SetNeedsRecomputeOverflow();
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698