Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2907523003: Fix TabSocket.onmessage whoch should be able to retrieve all messages (Closed)

Created:
3 years, 7 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 7 months ago
Reviewers:
Eric Seckler, eseckler
CC:
chromium-reviews, altimin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TabSocket.onmessage whoch should be able to retrieve all messages The previous patch https://codereview.chromium.org/2873283002/ broke that. BUG=546953 Review-Url: https://codereview.chromium.org/2907523003 Cr-Commit-Position: refs/heads/master@{#474643} Committed: https://chromium.googlesource.com/chromium/src/+/fb9a235342811e5c63be2ae03956c126b745fc0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M headless/lib/headless_web_contents_browsertest.cc View 2 chunks +14 lines, -3 lines 0 comments Download
M headless/lib/renderer/headless_content_renderer_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
alex clarke (OOO till 29th)
PTAL :)
3 years, 7 months ago (2017-05-25 13:34:04 UTC) #4
Eric Seckler
lgtm
3 years, 7 months ago (2017-05-25 13:40:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907523003/1
3 years, 7 months ago (2017-05-25 14:00:56 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 14:19:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fb9a235342811e5c63be2ae03956...

Powered by Google App Engine
This is Rietveld 408576698