Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: headless/lib/headless_web_contents_browsertest.cc

Issue 2907523003: Fix TabSocket.onmessage whoch should be able to retrieve all messages (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/lib/renderer/headless_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/headless_web_contents_browsertest.cc
diff --git a/headless/lib/headless_web_contents_browsertest.cc b/headless/lib/headless_web_contents_browsertest.cc
index dc4434c513c2edb18c0e54bb17ba3e417547d6c2..64550c0dcef982468e48a8db448a130a31ae621b 100644
--- a/headless/lib/headless_web_contents_browsertest.cc
+++ b/headless/lib/headless_web_contents_browsertest.cc
@@ -34,6 +34,7 @@
#include "ui/gfx/geometry/rect.h"
#endif
+using testing::ElementsAre;
using testing::UnorderedElementsAre;
namespace headless {
@@ -335,18 +336,28 @@ class HeadlessMainWorldTabSocketTest : public HeadlessAsyncDevTooledBrowserTest,
web_contents_->GetHeadlessTabSocket();
DCHECK(headless_tab_socket);
- headless_tab_socket->SendMessageToTab("Hello");
+ headless_tab_socket->SendMessageToTab("One");
+ headless_tab_socket->SendMessageToTab("Two");
+ headless_tab_socket->SendMessageToTab("Three");
headless_tab_socket->SetListener(this);
}
void OnMessageFromTab(const std::string& message) override {
- EXPECT_EQ("Embedder sent us: Hello", message);
- FinishAsynchronousTest();
+ messages_.push_back(message);
+ if (messages_.size() == 3u) {
+ EXPECT_THAT(messages_,
+ ElementsAre("Embedder sent us: One", "Embedder sent us: Two",
+ "Embedder sent us: Three"));
+ FinishAsynchronousTest();
+ }
}
HeadlessWebContents::Builder::TabSocketType GetTabSocketType() override {
return HeadlessWebContents::Builder::TabSocketType::MAIN_WORLD;
}
+
+ private:
+ std::vector<std::string> messages_;
};
HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessMainWorldTabSocketTest);
« no previous file with comments | « no previous file | headless/lib/renderer/headless_content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698