Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2907513003: Record first paint in UKM. (Closed)

Created:
3 years, 7 months ago by Bryan McQuade
Modified:
3 years, 7 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, speed-metrics-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Record first paint in UKM. BUG=705016 Review-Url: https://codereview.chromium.org/2907513003 Cr-Commit-Position: refs/heads/master@{#474803} Committed: https://chromium.googlesource.com/chromium/src/+/519e02399cd083a630bdbbd03a25bedf211b11a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Bryan McQuade
PTAL, thanks!
3 years, 7 months ago (2017-05-25 19:21:25 UTC) #5
Charlie Harrison
LGTM
3 years, 7 months ago (2017-05-25 19:49:34 UTC) #6
Charlie Harrison
There's no need to update an xml file or anything right? I'm not super familiar ...
3 years, 7 months ago (2017-05-25 19:49:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907513003/1
3 years, 7 months ago (2017-05-25 21:02:20 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 21:08:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/519e02399cd083a630bdbbd03a25...

Powered by Google App Engine
This is Rietveld 408576698