Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc

Issue 2907513003: Record first paint in UKM. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
index 4878e5178468d6646005a78c6ff2f3cb5f6c3ae1..f862f1c6d230f118c6c54db8c7a2e7b702f67dca 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
@@ -164,6 +164,7 @@ TEST_F(UkmPageLoadMetricsObserverTest, Basic) {
timing.parse_timing->parse_start = base::TimeDelta::FromMilliseconds(100);
timing.document_timing->dom_content_loaded_event_start =
base::TimeDelta::FromMilliseconds(200);
+ timing.paint_timing->first_paint = base::TimeDelta::FromMilliseconds(250);
timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(300);
timing.document_timing->load_event_start =
@@ -190,6 +191,7 @@ TEST_F(UkmPageLoadMetricsObserverTest, Basic) {
entry.get());
ExpectMetric(internal::kUkmParseStartName, 100, entry.get());
ExpectMetric(internal::kUkmDomContentLoadedName, 200, entry.get());
+ ExpectMetric(internal::kUkmFirstPaintName, 250, entry.get());
ExpectMetric(internal::kUkmFirstContentfulPaintName, 300, entry.get());
ExpectMetric(internal::kUkmLoadEventName, 500, entry.get());
EXPECT_FALSE(HasMetric(internal::kUkmFirstMeaningfulPaintName, entry.get()));
« no previous file with comments | « chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698