Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2907513002: [Code cleaning] Change hard-coded constants to predefined constant variables in JumpList (Closed)

Created:
3 years, 6 months ago by chengx
Modified:
3 years, 6 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change hard-coded constants to predefined constant variables in JumpList This CL changes hard-coded constants to predefined constant variables which were introduced in a previous CL. BUG=715902 Review-Url: https://codereview.chromium.org/2907513002 Cr-Commit-Position: refs/heads/master@{#475309} Committed: https://chromium.googlesource.com/chromium/src/+/04f0f9434101306e5fe99f0ab76411dc1a75b31d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/win/jumplist.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
chengx
This is a small CL to clean the code after introducing several constant variables in ...
3 years, 6 months ago (2017-05-25 04:24:03 UTC) #8
grt (UTC plus 2)
lgtm
3 years, 6 months ago (2017-05-29 07:22:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907513002/1
3 years, 6 months ago (2017-05-29 07:48:17 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 08:22:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04f0f9434101306e5fe99f0ab764...

Powered by Google App Engine
This is Rietveld 408576698