[Code cleaning] Change hard-coded constants to predefined constant variables in JumpList

chrome/browser/win/jumplist.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/win/jumplist.h"
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 42 matching lines @@
 
 using content::BrowserThread;
 using JumpListData = JumpList::JumpListData;
 
 namespace {
 
 // The default maximum number of items to display in JumpList is 10.
 // https://msdn.microsoft.com/library/windows/desktop/dd378398.aspx
 // The "Most visited" and "Recently closed" category titles always take 2 slots.
 // For the remaining 8 slots, we allocate 5 slots to "most-visited" items and 3
-// slots to"recently-closed" items, respectively.
+// slots to "recently-closed" items, respectively.
 constexpr size_t kMostVisitedItems = 5;
 constexpr size_t kRecentlyClosedItems = 3;
 
 // The number of updates to skip to alleviate the machine when a previous update
 // was too slow.
 constexpr int kUpdatesToSkipUnderHeavyLoad = 10;
 
 // The delay before updating the JumpList to prevent update storms.
 constexpr base::TimeDelta kDelayForJumplistUpdate =
     base::TimeDelta::FromMilliseconds(3500);
@@ skipping 605 matching lines @@
 
   return icons_created;
 }
 
 int JumpList::UpdateIconFiles(const base::FilePath& icon_dir,
                               const ShellLinkItemList& page_list,
                               size_t slot_limit,
                               JumpListCategory category) {
   int icons_created = 0;
 
-  // Maximum number of icon files that each JumpList icon folder may hold.
-  size_t icon_limit = (category == JumpListCategory::kMostVisited) ? 10 : 6;
+  // Maximum number of icon files that each JumpList icon folder may hold, which
+  // is set to 2 times the normal amount.
+  size_t icon_limit =
+      2 * ((category == JumpListCategory::kMostVisited) ? kMostVisitedItems
+                                                        : kRecentlyClosedItems);
 
   // Clear the JumpList icon folder at |icon_dir| and the cache when
   // 1) "Most visited" category updates for the 1st time after Chrome is
   //     launched. This actually happens right after Chrome is launched.
   // 2) "Recently closed" category updates for the 1st time after Chrome is
   //     launched.
   // 3) The number of icons in |icon_dir| has exceeded the limit.
   if ((category == JumpListCategory::kMostVisited &&
        most_visited_icons_.empty()) ||
       (category == JumpListCategory::kRecentlyClosed &&
@@ skipping 155 matching lines @@
           app_id, profile_dir, local_most_visited_pages,
           local_recently_closed_pages, most_visited_pages_have_updates,
           recently_closed_pages_have_updates, incognito_availability)) {
     base::AutoLock auto_lock(data->list_lock_);
     if (most_visited_pages_have_updates)
       data->most_visited_pages_have_updates_ = true;
     if (recently_closed_pages_have_updates)
       data->recently_closed_pages_have_updates_ = true;
   }
 }