Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2907033002: Bluetooth: macOS: Making code to get mac descriptors more coherent (Closed)

Created:
3 years, 6 months ago by jlebel
Modified:
3 years, 6 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Bluetooth: macOS: Making code to get mac descriptors more coherent Implementing BluetoothRemoteGattServiceMac::GetBluetoothRemoteGattDescriptorMac() to have a code more coherent from BluetoothLowEnergyDeviceMac point of view. BUG=727053 Review-Url: https://codereview.chromium.org/2907033002 Cr-Commit-Position: refs/heads/master@{#479355} Committed: https://chromium.googlesource.com/chromium/src/+/ba10cfa18f9faa0ea95da2157b507ae34e18ca33

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 1 chunk +7 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.h View 3 chunks +6 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_mac.mm View 2 chunks +16 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (11 generated)
jlebel
Hello Vincent, Can you review this patch? Thanks,
3 years, 6 months ago (2017-06-13 22:34:55 UTC) #8
scheib
lgtm
3 years, 6 months ago (2017-06-14 04:00:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2907033002/120001
3 years, 6 months ago (2017-06-14 10:57:50 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 12:12:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/ba10cfa18f9faa0ea95da2157b50...

Powered by Google App Engine
This is Rietveld 408576698