chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h - Issue 2906893004: Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h

Issue 2906893004: Omnibox UI Experiments: Port Vertical Layout experiment to Mac Cocoa. (Closed)

Patch Set: fix camel case Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm » ('j') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_

6 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_	6 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #include "base/mac/scoped_nsobject.h"	10 #include "base/mac/scoped_nsobject.h"

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61	61

62 // Returns the offset of the start of the contents in the input text for the	62 // Returns the offset of the start of the contents in the input text for the

63 // given match. It is costly to compute this offset, so it is computed once and	63 // given match. It is costly to compute this offset, so it is computed once and

64 // shared by all OmniboxPopupCell instances through OmniboxPopupViewMac parent.	64 // shared by all OmniboxPopupCell instances through OmniboxPopupViewMac parent.

65 + (CGFloat)computeContentsOffset:(const AutocompleteMatch&)match;	65 + (CGFloat)computeContentsOffset:(const AutocompleteMatch&)match;

66	66

67 + (NSAttributedString*)createSeparatorStringForDarkTheme:(BOOL)isDarkTheme;	67 + (NSAttributedString*)createSeparatorStringForDarkTheme:(BOOL)isDarkTheme;

68	68

69 + (CGFloat)getContentAreaWidth:(NSRect)cellFrame;	69 + (CGFloat)getContentAreaWidth:(NSRect)cellFrame;

70	70

71 + (CGFloat)getContentTextHeight;	71 + (CGFloat)getContentTextHeight:(BOOL)isTwoLine;
	groby-ooo-7-16 2017/05/31 00:14:51 Goal for cocoa functions is usually to be readable Goal for cocoa functions is usually to be readable without additional header search. Bool parameters make that hard :) Suggestion: getContentTextHeightForDoubleLine:(BOOL) (I'm not super-happy with that either, but we already do it above with ForDarkTheme) tommycli 2017/05/31 18:20:39 Done. Show quoted text On 2017/05/31 00:14:51, groby wrote: > Goal for cocoa functions is usually to be readable without additional header > search. Bool parameters make that hard :) > > Suggestion: > getContentTextHeightForDoubleLine:(BOOL) > > (I'm not super-happy with that either, but we already do it above with > ForDarkTheme) Done.
72	72

73 @end	73 @end

74	74

75 #endif // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_	75 #endif // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_CELL_H_

OLD	NEW