[Extenisons UI] Remove extension_action_redesign logic from the toolbar

[Extenisons UI] Remove extension_action_redesign logic from the toolbar

The extension action redesign has launched. Remove associated logic from
the ToolbarActionsBar, ToolbarActionsModel, and associated tests
(including ExtensionMesageBubbleBrowserTests).

BUG=590321
Review-Url: https://codereview.chromium.org/2906723003
Cr-Commit-Position: refs/heads/master@{#475737}
Committed: https://chromium.googlesource.com/chromium/src/+/5bb68a73901bc3d498901f02f9454576c6b033d3

[Devlin, 2017-05-26 16:30:43]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 16:31:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 16:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 16:33:27]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Devlin, 2017-05-26 17:29:20]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 17:29:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 18:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 18:34:02]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-27 00:58:00]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2017-05-27 00:58:01]

Heya Finnur, mind taking a look?

[Finnur, 2017-05-30 13:26:16]

LGTM, modulo one comment below.

https://codereview.chromium.org/2906723003/diff/20001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
(right):

https://codereview.chromium.org/2906723003/diff/20001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc:128:
no_action_extension->id(), extensions::Extension::DISABLE_NOT_VERIFIED);
It is not immediately obvious why this (and below) is related to removing the
last remnants of this toolbar-redesign-flag....

[Devlin, 2017-05-30 20:34:55]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-30 20:35:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 21:52:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 21:52:38]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-05-30 22:33:31]

https://codereview.chromium.org/2906723003/diff/20001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc
(right):

https://codereview.chromium.org/2906723003/diff/20001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/extension_message_bubble_browsertest.cc:128:
no_action_extension->id(), extensions::Extension::DISABLE_NOT_VERIFIED);
On 2017/05/30 13:26:15, Finnur wrote:
> It is not immediately obvious why this (and below) is related to removing the
> last remnants of this toolbar-redesign-flag....

Good point!  The reason is that, now that all extensions have actions, very few
bubbles still anchor to the app menu.  The suspicious extension bubble (warning
users about extensions that were disabled for not being from the webstore) is
one of the ones that does, so we trigger that one instead of the dev mode
bubble.

I've added comments to document this.

[Devlin, 2017-05-30 22:33:49]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2017-05-30 22:33:50]

Avi, mind taking a quick look at c/b/ui/cocoa?

[Avi (use Gerrit), 2017-05-31 01:45:10]

lgtm

[Devlin, 2017-05-31 01:52:01]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-05-31 01:52:01]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2906723003/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-05-31 01:53:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 01:59:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496195521375430,
"parent_rev": "e50a33061a1efd977881cc37eb53e762497393c9", "commit_rev":
"5bb68a73901bc3d498901f02f9454576c6b033d3"}

[commit-bot: I haz the power, 2017-05-31 01:59:55]

Description was changed from

==========
[Extenisons UI] Remove extension_action_redesign logic from the toolbar

The extension action redesign has launched. Remove associated logic from
the ToolbarActionsBar, ToolbarActionsModel, and associated tests
(including ExtensionMesageBubbleBrowserTests).

BUG=590321
==========

to

==========
[Extenisons UI] Remove extension_action_redesign logic from the toolbar

The extension action redesign has launched. Remove associated logic from
the ToolbarActionsBar, ToolbarActionsModel, and associated tests
(including ExtensionMesageBubbleBrowserTests).

BUG=590321

Review-Url: https://codereview.chromium.org/2906723003
Cr-Commit-Position: refs/heads/master@{#475737}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bb68a73901bc3d498901f02f945...
==========

[commit-bot: I haz the power, 2017-05-31 01:59:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5bb68a73901bc3d498901f02f945...