Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm

Issue 2906723003: [Extenisons UI] Remove extension_action_redesign logic from the toolbar (Closed)
Patch Set: comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_message_bubble_bridge.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "chrome/browser/ui/browser_window.h" 6 #include "chrome/browser/ui/browser_window.h"
7 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 7 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
8 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h" 8 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
9 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h" 9 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
10 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h" 10 #import "chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.h"
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override; 98 void CheckBubbleNative(Browser* browser, AnchorPosition anchor) override;
99 void CloseBubbleNative(Browser* browser) override; 99 void CloseBubbleNative(Browser* browser) override;
100 void CheckBubbleIsNotPresentNative(Browser* browser) override; 100 void CheckBubbleIsNotPresentNative(Browser* browser) override;
101 void ClickLearnMoreButton(Browser* browser) override; 101 void ClickLearnMoreButton(Browser* browser) override;
102 void ClickActionButton(Browser* browser) override; 102 void ClickActionButton(Browser* browser) override;
103 void ClickDismissButton(Browser* browser) override; 103 void ClickDismissButton(Browser* browser) override;
104 104
105 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac); 105 DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleBrowserTestMac);
106 }; 106 };
107 107
108 class ExtensionMessageBubbleBrowserTestLegacyMac
109 : public ExtensionMessageBubbleBrowserTestMac {
110 protected:
111 void SetUpCommandLine(base::CommandLine* command_line) override {
112 ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(command_line);
113 override_redesign_.reset();
114 override_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride(
115 extensions::FeatureSwitch::extension_action_redesign(), false));
116 }
117 };
118
119 void ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine( 108 void ExtensionMessageBubbleBrowserTestMac::SetUpCommandLine(
120 base::CommandLine* command_line) { 109 base::CommandLine* command_line) {
121 ExtensionMessageBubbleBrowserTest::SetUpCommandLine(command_line); 110 ExtensionMessageBubbleBrowserTest::SetUpCommandLine(command_line);
122 [ToolbarActionsBarBubbleMac setAnimationEnabledForTesting:NO]; 111 [ToolbarActionsBarBubbleMac setAnimationEnabledForTesting:NO];
123 } 112 }
124 113
125 void ExtensionMessageBubbleBrowserTestMac::CheckBubbleNative( 114 void ExtensionMessageBubbleBrowserTestMac::CheckBubbleNative(
126 Browser* browser, 115 Browser* browser,
127 AnchorPosition anchor) { 116 AnchorPosition anchor) {
128 ToolbarController* toolbarController = ToolbarControllerForBrowser(browser); 117 ToolbarController* toolbarController = ToolbarControllerForBrowser(browser);
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 Browser* browser) { 162 Browser* browser) {
174 ToolbarActionsBarBubbleMac* bubble = GetBubbleForBrowser(browser); 163 ToolbarActionsBarBubbleMac* bubble = GetBubbleForBrowser(browser);
175 ClickInView([bubble dismissButton]); 164 ClickInView([bubble dismissButton]);
176 } 165 }
177 166
178 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 167 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
179 ExtensionBubbleAnchoredToExtensionAction) { 168 ExtensionBubbleAnchoredToExtensionAction) {
180 TestBubbleAnchoredToExtensionAction(); 169 TestBubbleAnchoredToExtensionAction();
181 } 170 }
182 171
183 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac, 172 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
184 ExtensionBubbleAnchoredToAppMenu) { 173 ExtensionBubbleAnchoredToAppMenu) {
185 TestBubbleAnchoredToAppMenu(); 174 TestBubbleAnchoredToAppMenu();
186 } 175 }
187 176
188 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestLegacyMac, 177 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
189 ExtensionBubbleAnchoredToAppMenuWithOtherAction) { 178 ExtensionBubbleAnchoredToAppMenuWithOtherAction) {
190 TestBubbleAnchoredToAppMenuWithOtherAction(); 179 TestBubbleAnchoredToAppMenuWithOtherAction();
191 } 180 }
192 181
193 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 182 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
194 PRE_ExtensionBubbleShowsOnStartup) { 183 PRE_ExtensionBubbleShowsOnStartup) {
195 PreBubbleShowsOnStartup(); 184 PreBubbleShowsOnStartup();
196 } 185 }
197 186
198 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 187 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 241
253 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 242 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
254 PRE_TestControlledStartupNotShownOnRestart) { 243 PRE_TestControlledStartupNotShownOnRestart) {
255 PreTestControlledStartupNotShownOnRestart(); 244 PreTestControlledStartupNotShownOnRestart();
256 } 245 }
257 246
258 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac, 247 IN_PROC_BROWSER_TEST_F(ExtensionMessageBubbleBrowserTestMac,
259 TestControlledStartupNotShownOnRestart) { 248 TestControlledStartupNotShownOnRestart) {
260 TestControlledStartupNotShownOnRestart(); 249 TestControlledStartupNotShownOnRestart();
261 } 250 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/extensions/extension_message_bubble_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698