Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 2906693003: [mus+ash] Removes WmWindow from screen_dimmer and video_detector (Closed)

Created:
3 years, 7 months ago by varkha
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, posciak+watch_chromium.org, nektar+watch_chromium.org, je_julie, yuzo+watch_chromium.org, aboxhall+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from screen_dimmer and video_detector BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2906693003 Cr-Commit-Position: refs/heads/master@{#474832} Committed: https://chromium.googlesource.com/chromium/src/+/c71444e5419f060125cfdabe732bad8175d748c1

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from screen_dimmer and video_detector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -68 lines) Patch
M ash/high_contrast/high_contrast_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/high_contrast/high_contrast_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wallpaper/wallpaper_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wallpaper/wallpaper_controller.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M ash/wallpaper/wallpaper_view.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/wallpaper/wallpaper_view.cc View 6 chunks +20 lines, -17 lines 0 comments Download
M ash/wm/screen_dimmer.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/wm/screen_dimmer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/video_detector.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
varkha
sky@, PTAL, this still needs https://codereview.chromium.org/2904073002 to land first. With this there should be no ...
3 years, 7 months ago (2017-05-25 21:14:59 UTC) #2
sky
LGTM
3 years, 7 months ago (2017-05-25 22:34:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2906693003/40001
3 years, 7 months ago (2017-05-25 22:45:27 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 22:52:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c71444e5419f060125cfdabe732b...

Powered by Google App Engine
This is Rietveld 408576698