Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2904073002: [mus+ash] Removes WmWindow from ash/wm/screen_pinning_controller.h (Closed)

Created:
3 years, 6 months ago by varkha
Modified:
3 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[mus+ash] Removes WmWindow from ash/wm/screen_pinning_controller.h BUG=722553 TEST=None (refactoring) Review-Url: https://codereview.chromium.org/2904073002 Cr-Commit-Position: refs/heads/master@{#474806} Committed: https://chromium.googlesource.com/chromium/src/+/19d7e6c565f69afe7d6e20e6def303033faa1be6

Patch Set 1 #

Patch Set 2 : [mus+ash] Removes WmWindow from ash/wm/screen_pinning_controller.h (removes unneeded header) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -99 lines) Patch
M ash/accelerators/accelerator_commands_aura.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/default_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_pinning_controller.h View 3 chunks +10 lines, -11 lines 0 comments Download
M ash/wm/screen_pinning_controller.cc View 12 chunks +60 lines, -75 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
varkha
sky@, can you please take a look? Thanks!
3 years, 6 months ago (2017-05-25 19:43:43 UTC) #3
sky
LGTM
3 years, 6 months ago (2017-05-25 19:57:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904073002/20001
3 years, 6 months ago (2017-05-25 20:31:34 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-25 21:15:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/19d7e6c565f69afe7d6e20e6def3...

Powered by Google App Engine
This is Rietveld 408576698