Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

Issue 2906633004: Modify PrinterSetupResult enum to constant style. (Closed)
Patch Set: typo Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h" 5 #include "chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 printer_copy, 249 printer_copy,
250 base::Bind(&CupsPrintersHandler::OnAddedPrinter, 250 base::Bind(&CupsPrintersHandler::OnAddedPrinter,
251 weak_factory_.GetWeakPtr(), base::Passed(&printer))); 251 weak_factory_.GetWeakPtr(), base::Passed(&printer)));
252 } 252 }
253 253
254 void CupsPrintersHandler::OnAddedPrinter( 254 void CupsPrintersHandler::OnAddedPrinter(
255 std::unique_ptr<Printer> printer, 255 std::unique_ptr<Printer> printer,
256 chromeos::PrinterSetupResult result_code) { 256 chromeos::PrinterSetupResult result_code) {
257 std::string printer_name = printer->display_name(); 257 std::string printer_name = printer->display_name();
258 switch (result_code) { 258 switch (result_code) {
259 case chromeos::PrinterSetupResult::SUCCESS: { 259 case chromeos::PrinterSetupResult::kSuccess: {
260 auto* manager = PrintersManagerFactory::GetForBrowserContext(profile_); 260 auto* manager = PrintersManagerFactory::GetForBrowserContext(profile_);
261 manager->PrinterInstalled(*printer); 261 manager->PrinterInstalled(*printer);
262 manager->RegisterPrinter(std::move(printer)); 262 manager->RegisterPrinter(std::move(printer));
263 break; 263 break;
264 } 264 }
265 case chromeos::PrinterSetupResult::PPD_NOT_FOUND: 265 case chromeos::PrinterSetupResult::kPpdNotFound:
266 LOG(WARNING) << "Could not locate requested PPD"; 266 LOG(WARNING) << "Could not locate requested PPD";
267 break; 267 break;
268 case chromeos::PrinterSetupResult::PPD_TOO_LARGE: 268 case chromeos::PrinterSetupResult::kPpdTooLarge:
269 LOG(WARNING) << "PPD is too large"; 269 LOG(WARNING) << "PPD is too large";
270 break; 270 break;
271 case chromeos::PrinterSetupResult::PPD_UNRETRIEVABLE: 271 case chromeos::PrinterSetupResult::kPpdUnretrievable:
272 LOG(WARNING) << "Could not retrieve PPD from server"; 272 LOG(WARNING) << "Could not retrieve PPD from server";
273 break; 273 break;
274 case chromeos::PrinterSetupResult::INVALID_PPD: 274 case chromeos::PrinterSetupResult::kInvalidPpd:
275 LOG(WARNING) << "Provided PPD is invalid."; 275 LOG(WARNING) << "Provided PPD is invalid.";
276 break; 276 break;
277 case chromeos::PrinterSetupResult::PRINTER_UNREACHABLE: 277 case chromeos::PrinterSetupResult::kPrinterUnreachable:
278 LOG(WARNING) << "Could not contact printer for configuration"; 278 LOG(WARNING) << "Could not contact printer for configuration";
279 break; 279 break;
280 case chromeos::PrinterSetupResult::DBUS_ERROR: 280 case chromeos::PrinterSetupResult::kDbusError:
281 case chromeos::PrinterSetupResult::FATAL_ERROR: 281 case chromeos::PrinterSetupResult::kFatalError:
282 LOG(ERROR) << "Unrecoverable error. Reboot required."; 282 LOG(ERROR) << "Unrecoverable error. Reboot required.";
283 break; 283 break;
284 case chromeos::PrinterSetupResult::kMaxValue:
285 NOTREACHED() << "This is not an expected value";
286 break;
284 } 287 }
285 CallJavascriptFunction( 288 CallJavascriptFunction(
286 "cr.webUIListenerCallback", base::Value("on-add-cups-printer"), 289 "cr.webUIListenerCallback", base::Value("on-add-cups-printer"),
287 base::Value(result_code == chromeos::PrinterSetupResult::SUCCESS), 290 base::Value(result_code == chromeos::PrinterSetupResult::kSuccess),
288 base::Value(printer_name)); 291 base::Value(printer_name));
289 } 292 }
290 293
291 void CupsPrintersHandler::OnAddPrinterError() { 294 void CupsPrintersHandler::OnAddPrinterError() {
292 FireWebUIListener("on-add-cups-printer", base::Value(false), base::Value("")); 295 FireWebUIListener("on-add-cups-printer", base::Value(false), base::Value(""));
293 } 296 }
294 297
295 void CupsPrintersHandler::HandleGetCupsPrinterManufacturers( 298 void CupsPrintersHandler::HandleGetCupsPrinterManufacturers(
296 const base::ListValue* args) { 299 const base::ListValue* args) {
297 AllowJavascript(); 300 AllowJavascript();
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 412
410 FireWebUIListener("on-printer-discovered", *printers_list); 413 FireWebUIListener("on-printer-discovered", *printers_list);
411 } 414 }
412 415
413 void CupsPrintersHandler::OnDiscoveryInitialScanDone() { 416 void CupsPrintersHandler::OnDiscoveryInitialScanDone() {
414 FireWebUIListener("on-printer-discovery-done"); 417 FireWebUIListener("on-printer-discovery-done");
415 } 418 }
416 419
417 } // namespace settings 420 } // namespace settings
418 } // namespace chromeos 421 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698