[Bindings] Export constructorCallback functions in generated code

[Bindings] Export constructorCallback functions in generated code

Callback functions to pass to V8 API need to be referable from other
components to put in a snapshot reference table.

BUG=617892
Review-Url: https://codereview.chromium.org/2906613002
Cr-Commit-Position: refs/heads/master@{#474589}
Committed: https://chromium.googlesource.com/chromium/src/+/449dd5f8fd2cba658972a39b150d2d40282934a7

[peria, 2017-05-25 03:07:25]

peria@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org, yukishiino@chromium.org

[peria, 2017-05-25 03:07:26]

PTL

[peria, 2017-05-25 03:07:32]

The CQ bit was checked by peria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 03:08:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2017-05-25 03:41:16]

lgtm.

I think describing the purpose of this change is preferable (not just bug
number) to make `git log` useful.

https://codereview.chromium.org/2906613002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h
(right):

https://codereview.chromium.org/2906613002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h:57: 
nit: can we make template not adding this empty line?

[haraken, 2017-05-25 03:42:41]

LGTM

[peria, 2017-05-25 04:32:56]

Description was changed from

==========
[Bindings] Export constructorCallback functions in generated code

BUG=617892
==========

to

==========
[Bindings] Export constructorCallback functions in generated code

Callback functions to pass to V8 API need to be referable from other
components to put in a snapshot reference table.

BUG=617892
==========

[peria, 2017-05-25 04:34:00]

The CQ bit was checked by peria@chromium.org

[peria, 2017-05-25 04:34:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2906613002/#ps20001
(title: "remove an empty line")

[peria, 2017-05-25 04:34:24]

https://codereview.chromium.org/2906613002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h
(right):

https://codereview.chromium.org/2906613002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h:57: 
On 2017/05/25 03:41:16, bashi wrote:
> nit: can we make template not adding this empty line?

Done.

[commit-bot: I haz the power, 2017-05-25 04:34:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2017-05-25 06:17:28]

LGTM.

[commit-bot: I haz the power, 2017-05-25 06:47:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495686840029790,
"parent_rev": "0ceaba5ef538ce1780578d5e948641bc27f5829b", "commit_rev":
"449dd5f8fd2cba658972a39b150d2d40282934a7"}

[commit-bot: I haz the power, 2017-05-25 06:48:11]

Description was changed from

==========
[Bindings] Export constructorCallback functions in generated code

Callback functions to pass to V8 API need to be referable from other
components to put in a snapshot reference table.

BUG=617892
==========

to

==========
[Bindings] Export constructorCallback functions in generated code

Callback functions to pass to V8 API need to be referable from other
components to put in a snapshot reference table.

BUG=617892

Review-Url: https://codereview.chromium.org/2906613002
Cr-Commit-Position: refs/heads/master@{#474589}
Committed:
https://chromium.googlesource.com/chromium/src/+/449dd5f8fd2cba658972a39b150d...
==========

[commit-bot: I haz the power, 2017-05-25 06:48:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/449dd5f8fd2cba658972a39b150d...