Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h.tmpl

Issue 2906613002: [Bindings] Export constructorCallback functions in generated code (Closed)
Patch Set: remove an empty line Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/templates/interface.h.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
index 36a395cf39eda02f5d7f5708f6e6838b7cd158e2..b3104f256644f947903f91d6d706e7cf7f8fa8b3 100644
--- a/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
@@ -62,9 +62,6 @@ class {{v8_class}} {
static void {{method.name}}MethodEpilogueCustom(const v8::FunctionCallbackInfo<v8::Value>&, {{cpp_class}}*);
{% endif %}
{% endfor %}
- {% if constructors or has_custom_constructor or has_html_constructor %}
- static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
- {% endif %}
{% if has_custom_constructor %}
static void constructorCustom(const v8::FunctionCallbackInfo<v8::Value>&);
{% endif %}
@@ -151,6 +148,10 @@ class {{v8_class}} {
{% endfor %}
// Callback functions
+ {% if constructors or has_custom_constructor or has_html_constructor %}
+ {{exported}}static void constructorCallback(const v8::FunctionCallbackInfo<v8::Value>&);
+
+ {% endif %}
{% for constant in constants | has_special_getter %}
{{exported}}static void {{constant.name}}ConstantGetterCallback(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&);
{% endfor %}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestException.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698