Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 290653003: libvpx: Pull from upstream (Closed)

Created:
6 years, 7 months ago by Johann
Modified:
6 years, 7 months ago
Reviewers:
fgalligan1, Tom Finegan
CC:
chromium-reviews, wwcv, jzern
Visibility:
Public.

Description

libvpx: Pull from upstream Add arm64 target Allow passing a URL to update_libvpx.sh Don't lint mipsel headers because they don't exist Current HEAD: c511d79c081ef8ca2bb2f9a096f893370cb9187b git log from upstream: 7fc5e74 Reuse precalculated result 7083560 set_map.c: cleanup -wextra warnings 04c40d3 cleanup -wextra warnings: 21bb6dd vp9_firstpass.c: clean -wextra warnings e623056 vp9_pickmode.c: cleanup -wextra warnings d722795 vp9_rdopt.c: cleanup -wextra warnings ed784a0 Removing redundant "8x8" suffix from MODE_INFO vars. bf8c58b Refactor calling loopfilter code. a16794d Revert "Remove Wextra warnings from vp9_sad.c" 6471dd7 Removing unused img_setup field. 2f6f955 Remove intermediate step in vp8_dequantize_b 4dcc6d9 Build armv7a-only code 1fbab85 AVX2 To VP9 Block Error Optimization a77d6d0 Rename vpx_temporal_scalable_patterns.c 96d1946 Revert "Revert "Remove struct params from vp8_denoiser_filter"" 6f35081 vp9_ratectrl.c: cleanup -wextra warning 051332a vp9_tokenize.c: cleanup -wextra warnings ed09580 vp9_decodeframe.c: cleanup -wextra warnings c39a361 vp9_quantizer.c: cleanup -wextra warnings 69544cf Clear unused parameter warning. e05a17b vp9_mbgraph.c: cleanup -wextra warnings 82cf107 Silence unused parameter warnings. 2493e0f Fix int compared to unsigned int warnings. 200f9ae Silence unused parameter warnings. 7b4258d Clean up two unused parameters. 6122ca8 Simplify 2 pass KF bitrate allocation <...> R=fgalligan@chromium.org TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271029

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4913 lines, -3035 lines) Patch
M README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M generate_gypi.sh View 1 2 5 chunks +17 lines, -3 lines 2 comments Download
M libvpx.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M libvpx_srcs_arm.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A libvpx_srcs_arm64.gypi View 1 chunk +325 lines, -0 lines 0 comments Download
M libvpx_srcs_arm_neon.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M libvpx_srcs_arm_neon_cpu_detect.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M libvpx_srcs_x86.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M libvpx_srcs_x86_64.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm-neon-cpu-detect/vp8_rtcd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M source/config/linux/arm-neon-cpu-detect/vp9_rtcd.h View 2 chunks +5 lines, -5 lines 0 comments Download
M source/config/linux/arm-neon-cpu-detect/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm-neon-cpu-detect/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm-neon/vp8_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/linux/arm-neon/vp9_rtcd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M source/config/linux/arm-neon/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm-neon/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm/vp8_rtcd.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/arm/vp9_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/linux/arm/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/arm/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
A source/config/linux/arm64/vp8_rtcd.h View 1 1 chunk +378 lines, -0 lines 0 comments Download
A source/config/linux/arm64/vp9_rtcd.h View 1 1 chunk +671 lines, -0 lines 0 comments Download
A source/config/linux/arm64/vpx_config.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
A source/config/linux/arm64/vpx_config.asm View 1 1 chunk +84 lines, -0 lines 0 comments Download
A source/config/linux/arm64/vpx_config.c View 1 1 chunk +9 lines, -0 lines 0 comments Download
A source/config/linux/arm64/vpx_scale_rtcd.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
M source/config/linux/generic/vp8_rtcd.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/generic/vp9_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/linux/generic/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/generic/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/ia32/vp8_rtcd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M source/config/linux/ia32/vp9_rtcd.h View 4 chunks +9 lines, -6 lines 0 comments Download
M source/config/linux/ia32/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/ia32/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/mipsel/vp8_rtcd.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/linux/mipsel/vp9_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/linux/mipsel/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/x64/vp8_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/linux/x64/vp9_rtcd.h View 3 chunks +8 lines, -4 lines 0 comments Download
M source/config/linux/x64/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/linux/x64/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/mac/ia32/vp8_rtcd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M source/config/mac/ia32/vp9_rtcd.h View 2 chunks +5 lines, -5 lines 0 comments Download
M source/config/mac/ia32/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/mac/ia32/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/mac/x64/vp8_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/mac/x64/vp9_rtcd.h View 3 chunks +8 lines, -4 lines 0 comments Download
M source/config/mac/x64/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/mac/x64/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/nacl/vp8_rtcd.h View 1 chunk +1 line, -1 line 0 comments Download
M source/config/nacl/vp9_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/nacl/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/nacl/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/win/ia32/vp8_rtcd.h View 1 chunk +3 lines, -3 lines 0 comments Download
M source/config/win/ia32/vp9_rtcd.h View 4 chunks +9 lines, -6 lines 0 comments Download
M source/config/win/ia32/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/win/ia32/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/win/x64/vp8_rtcd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M source/config/win/x64/vp9_rtcd.h View 3 chunks +8 lines, -4 lines 0 comments Download
M source/config/win/x64/vpx_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M source/config/win/x64/vpx_config.asm View 1 chunk +1 line, -0 lines 0 comments Download
M source/libvpx/README View 1 chunk +7 lines, -9 lines 0 comments Download
M source/libvpx/build/make/Android.mk View 4 chunks +12 lines, -4 lines 0 comments Download
M source/libvpx/build/make/configure.sh View 4 chunks +7 lines, -3 lines 0 comments Download
M source/libvpx/build/make/rtcd.pl View 2 chunks +7 lines, -1 line 0 comments Download
M source/libvpx/configure View 2 chunks +2 lines, -1 line 0 comments Download
M source/libvpx/docs.mk View 1 chunk +0 lines, -6 lines 0 comments Download
M source/libvpx/examples.mk View 2 chunks +16 lines, -26 lines 0 comments Download
D source/libvpx/examples/decode_with_partial_drops.c View 1 chunk +0 lines, -328 lines 0 comments Download
D source/libvpx/examples/example_xma.c View 1 chunk +0 lines, -193 lines 0 comments Download
M source/libvpx/examples/set_maps.c View 4 chunks +10 lines, -8 lines 0 comments Download
D source/libvpx/examples/vp9_spatial_scalable_encoder.c View 1 chunk +0 lines, -391 lines 0 comments Download
A source/libvpx/examples/vp9_spatial_svc_encoder.c View 1 chunk +391 lines, -0 lines 0 comments Download
D source/libvpx/examples/vpx_temporal_scalable_patterns.c View 1 chunk +0 lines, -667 lines 0 comments Download
A source/libvpx/examples/vpx_temporal_svc_encoder.c View 1 chunk +667 lines, -0 lines 0 comments Download
M source/libvpx/test/convolve_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/test/dct16x16_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/test/dct32x32_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/test/fdct4x4_test.cc View 2 chunks +8 lines, -1 line 0 comments Download
M source/libvpx/test/fdct8x8_test.cc View 2 chunks +8 lines, -1 line 0 comments Download
M source/libvpx/test/partial_idct_test.cc View 4 chunks +16 lines, -7 lines 0 comments Download
M source/libvpx/test/register_state_check.h View 1 chunk +2 lines, -2 lines 0 comments Download
A source/libvpx/test/resize_util.sh View 1 chunk +66 lines, -0 lines 0 comments Download
M source/libvpx/test/subtract_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/test/test.mk View 1 chunk +4 lines, -0 lines 0 comments Download
M source/libvpx/test/test-data.sha1 View 1 chunk +5 lines, -0 lines 0 comments Download
M source/libvpx/test/test_vectors.cc View 1 chunk +2 lines, -1 line 0 comments Download
M source/libvpx/test/tools_common.sh View 1 chunk +3 lines, -1 line 0 comments Download
A source/libvpx/test/twopass_encoder.sh View 1 chunk +59 lines, -0 lines 0 comments Download
M source/libvpx/test/variance_test.cc View 2 chunks +334 lines, -128 lines 0 comments Download
A source/libvpx/test/vp8cx_set_ref.sh View 1 chunk +54 lines, -0 lines 0 comments Download
M source/libvpx/vp8/common/arm/dequantize_arm.c View 1 chunk +0 lines, -17 lines 0 comments Download
M source/libvpx/vp8/common/arm/loopfilter_arm.c View 2 chunks +10 lines, -4 lines 0 comments Download
M source/libvpx/vp8/common/arm/neon/dequantizeb_neon.c View 1 chunk +5 lines, -7 lines 0 comments Download
A source/libvpx/vp8/common/arm/neon/idct_dequant_0_2x_neon.asm View 1 1 chunk +81 lines, -0 lines 0 comments Download
D source/libvpx/vp8/common/arm/neon/idct_dequant_0_2x_neon.c View 1 chunk +0 lines, -62 lines 0 comments Download
A source/libvpx/vp8/common/arm/neon/idct_dequant_full_2x_neon.asm View 1 1 chunk +199 lines, -0 lines 0 comments Download
D source/libvpx/vp8/common/arm/neon/idct_dequant_full_2x_neon.c View 1 chunk +0 lines, -185 lines 0 comments Download
M source/libvpx/vp8/common/arm/reconintra_arm.c View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp8/common/arm/variance_arm.c View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp8/common/rtcd_defs.pl View 11 chunks +45 lines, -25 lines 0 comments Download
M source/libvpx/vp8/encoder/arm/neon/denoising_neon.c View 2 chunks +6 lines, -12 lines 0 comments Download
M source/libvpx/vp8/encoder/denoising.c View 3 chunks +17 lines, -17 lines 0 comments Download
M source/libvpx/vp8/encoder/x86/denoising_sse2.c View 2 chunks +8 lines, -12 lines 0 comments Download
M source/libvpx/vp8/vp8_common.mk View 3 chunks +10 lines, -10 lines 0 comments Download
M source/libvpx/vp8/vp8_cx_iface.c View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp8/vp8cx_arm.mk View 1 chunk +8 lines, -7 lines 0 comments Download
M source/libvpx/vp9/common/arm/neon/vp9_idct8x8_add_neon.asm View 3 chunks +4 lines, -4 lines 0 comments Download
M source/libvpx/vp9/common/mips/dspr2/vp9_itrans8_dspr2.c View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp9/common/vp9_common.h View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp9/common/vp9_convolve.c View 6 chunks +20 lines, -0 lines 0 comments Download
M source/libvpx/vp9/common/vp9_debugmodes.c View 4 chunks +6 lines, -7 lines 0 comments Download
M source/libvpx/vp9/common/vp9_idct.c View 2 chunks +3 lines, -3 lines 0 comments Download
M source/libvpx/vp9/common/vp9_loopfilter.h View 1 chunk +2 lines, -1 line 0 comments Download
M source/libvpx/vp9/common/vp9_loopfilter.c View 4 chunks +12 lines, -11 lines 0 comments Download
M source/libvpx/vp9/common/vp9_reconintra.c View 9 chunks +12 lines, -1 line 0 comments Download
M source/libvpx/vp9/common/vp9_rtcd_defs.pl View 12 chunks +91 lines, -48 lines 0 comments Download
M source/libvpx/vp9/common/x86/vp9_idct_intrin_sse2.c View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp9/common/x86/vp9_idct_ssse3.asm View 3 chunks +138 lines, -0 lines 0 comments Download
M source/libvpx/vp9/decoder/vp9_decodeframe.c View 18 chunks +84 lines, -76 lines 0 comments Download
M source/libvpx/vp9/decoder/vp9_decoder.h View 4 chunks +4 lines, -13 lines 0 comments Download
M source/libvpx/vp9/decoder/vp9_decoder.c View 5 chunks +7 lines, -15 lines 0 comments Download
M source/libvpx/vp9/decoder/vp9_dthread.h View 1 chunk +3 lines, -2 lines 0 comments Download
M source/libvpx/vp9/decoder/vp9_dthread.c View 2 chunks +5 lines, -5 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_bitstream.c View 7 chunks +19 lines, -17 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_context_tree.c View 4 chunks +46 lines, -45 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_encodeframe.c View 30 chunks +125 lines, -73 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_encodemb.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_encoder.h View 2 chunks +1 line, -9 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_encoder.c View 12 chunks +22 lines, -84 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_firstpass.c View 9 chunks +137 lines, -226 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_mbgraph.c View 2 chunks +2 lines, -2 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_mcomp.h View 1 chunk +1 line, -2 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_mcomp.c View 2 chunks +5 lines, -1 line 0 comments Download
M source/libvpx/vp9/encoder/vp9_picklpf.c View 3 chunks +10 lines, -5 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_pickmode.c View 4 chunks +4 lines, -6 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_quantize.c View 2 chunks +2 lines, -0 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_ratectrl.c View 7 chunks +10 lines, -14 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_rdopt.c View 11 chunks +12 lines, -11 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_segmentation.c View 8 chunks +17 lines, -19 lines 0 comments Download
M source/libvpx/vp9/encoder/vp9_speed_features.h View 1 chunk +1 line, -1 line 0 comments Download
M source/libvpx/vp9/encoder/vp9_tokenize.c View 2 chunks +2 lines, -1 line 0 comments Download
A source/libvpx/vp9/encoder/x86/vp9_dct_mmx.asm View 1 chunk +70 lines, -0 lines 0 comments Download
A source/libvpx/vp9/encoder/x86/vp9_error_intrin_avx2.c View 1 chunk +72 lines, -0 lines 0 comments Download
M source/libvpx/vp9/vp9_common.mk View 1 chunk +23 lines, -23 lines 0 comments Download
M source/libvpx/vp9/vp9_cx_iface.c View 4 chunks +6 lines, -4 lines 0 comments Download
M source/libvpx/vp9/vp9_dx_iface.c View 3 chunks +49 lines, -64 lines 0 comments Download
M source/libvpx/vp9/vp9cx.mk View 1 chunk +2 lines, -0 lines 0 comments Download
M source/libvpx/vpx/src/svc_encodeframe.c View 1 chunk +2 lines, -1 line 0 comments Download
M source/libvpx/vpx_scale/vpx_scale.mk View 1 chunk +4 lines, -4 lines 0 comments Download
M source/libvpx/vpx_scale/vpx_scale_rtcd.pl View 1 chunk +4 lines, -2 lines 0 comments Download
M source/libvpx/vpxdec.c View 2 chunks +5 lines, -1 line 0 comments Download
M source/libvpx/vpxenc.c View 7 chunks +17 lines, -2 lines 0 comments Download
M update_libvpx.sh View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Johann
https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh File generate_gypi.sh (right): https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh#newcode356 generate_gypi.sh:356: #lint_config linux/mipsel mips does not pass lint. it was ...
6 years, 7 months ago (2014-05-16 15:22:31 UTC) #1
fgalligan1
https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh File generate_gypi.sh (right): https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh#newcode356 generate_gypi.sh:356: #lint_config linux/mipsel On 2014/05/16 15:22:32, Johann wrote: > mips ...
6 years, 7 months ago (2014-05-16 15:30:25 UTC) #2
fgalligan1
On 2014/05/16 15:30:25, fgalligan1 wrote: > https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh > File generate_gypi.sh (right): > > https://codereview.chromium.org/290653003/diff/1/generate_gypi.sh#newcode356 > ...
6 years, 7 months ago (2014-05-16 15:40:00 UTC) #3
Johann
https://codereview.chromium.org/290653003/diff/40001/generate_gypi.sh File generate_gypi.sh (right): https://codereview.chromium.org/290653003/diff/40001/generate_gypi.sh#newcode232 generate_gypi.sh:232: if [[ "$1" != *mipsel ]]; then couple different ...
6 years, 7 months ago (2014-05-16 15:42:52 UTC) #4
fgalligan1
https://codereview.chromium.org/290653003/diff/40001/generate_gypi.sh File generate_gypi.sh (right): https://codereview.chromium.org/290653003/diff/40001/generate_gypi.sh#newcode232 generate_gypi.sh:232: if [[ "$1" != *mipsel ]]; then On 2014/05/16 ...
6 years, 7 months ago (2014-05-16 15:49:48 UTC) #5
Johann
Committed patchset #3 manually as r271029 (presubmit successful).
6 years, 7 months ago (2014-05-16 15:51:24 UTC) #6
Tom Finegan
6 years, 7 months ago (2014-05-16 17:50:14 UTC) #7
Message was sent while issue was closed.
On 2014/05/16 15:51:24, Johann wrote:
> Committed patchset #3 manually as r271029 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698