Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: pkg/compiler/lib/src/kernel/fasta_support.dart

Issue 2906253004: Avoid using Invalid{Statement,Expression,Initializer}. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Additions to Fasta for generating .dill (Kernel IR) files with dart2js patch 5 /// Additions to Fasta for generating .dill (Kernel IR) files with dart2js patch
6 /// files and native hooks. 6 /// files and native hooks.
7 library compiler.src.kernel.fasta_support; 7 library compiler.src.kernel.fasta_support;
8 8
9 // TODO(sigmund): get rid of this file. Fasta should be agnostic of the 9 // TODO(sigmund): get rid of this file. Fasta should be agnostic of the
10 // target platform, at which point this should not be necessary. In particular, 10 // target platform, at which point this should not be necessary. In particular,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 KernelTargetForDart2js( 83 KernelTargetForDart2js(
84 DillTarget target, TranslateUri uriTranslator, bool strongMode, 84 DillTarget target, TranslateUri uriTranslator, bool strongMode,
85 [Map<String, Source> uriToSource]) 85 [Map<String, Source> uriToSource])
86 : super(PhysicalFileSystem.instance, target, uriTranslator, strongMode, 86 : super(PhysicalFileSystem.instance, target, uriTranslator, strongMode,
87 uriToSource); 87 uriToSource);
88 88
89 @override 89 @override
90 Token skipNativeClause(Token token) => _skipNative(token); 90 Token skipNativeClause(Token token) => _skipNative(token);
91 91
92 @override 92 @override
93 String extractNativeMethodName(Token token) => null; 93 String extractNativeMethodName(Token token) => "";
94 94
95 @override 95 @override
96 void loadExtraRequiredLibraries(Loader loader) => _loadExtras(loader); 96 void loadExtraRequiredLibraries(Loader loader) => _loadExtras(loader);
97 97
98 @override 98 @override
99 void runBuildTransformations() {} 99 void runBuildTransformations() {}
100 } 100 }
101 101
102 /// Specializes [DillTarget] to build kernel for dart2js: JS-specific libraries 102 /// Specializes [DillTarget] to build kernel for dart2js: JS-specific libraries
103 /// are included in the SDK, and native clauses have no string parameter. 103 /// are included in the SDK, and native clauses have no string parameter.
104 class DillTargetForDart2js extends DillTarget { 104 class DillTargetForDart2js extends DillTarget {
105 DillTargetForDart2js(Ticker ticker, TranslateUri uriTranslator) 105 DillTargetForDart2js(Ticker ticker, TranslateUri uriTranslator)
106 : super(ticker, uriTranslator, "none"); 106 : super(ticker, uriTranslator, "none");
107 107
108 @override 108 @override
109 Token skipNativeClause(Token token) => _skipNative(token); 109 Token skipNativeClause(Token token) => _skipNative(token);
110 110
111 @override 111 @override
112 String extractNativeMethodName(Token token) => null; 112 String extractNativeMethodName(Token token) => "";
113 113
114 @override 114 @override
115 void loadExtraRequiredLibraries(Loader loader) => _loadExtras(loader); 115 void loadExtraRequiredLibraries(Loader loader) => _loadExtras(loader);
116 } 116 }
117 117
118 /// We use native clauses of this form in our dart2js patch files: 118 /// We use native clauses of this form in our dart2js patch files:
119 /// 119 ///
120 /// methodDeclaration() native; 120 /// methodDeclaration() native;
121 /// 121 ///
122 /// The default front_end parser doesn't support this, so it will trigger an 122 /// The default front_end parser doesn't support this, so it will trigger an
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 'dart:html_common', 155 'dart:html_common',
156 'dart:indexed_db', 156 'dart:indexed_db',
157 'dart:js', 157 'dart:js',
158 'dart:js_util', 158 'dart:js_util',
159 'dart:mirrors', 159 'dart:mirrors',
160 'dart:svg', 160 'dart:svg',
161 'dart:web_audio', 161 'dart:web_audio',
162 'dart:web_gl', 162 'dart:web_gl',
163 'dart:web_sql', 163 'dart:web_sql',
164 ]; 164 ];
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698