Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2906173002:
VR: Content size incorrect when transitioning from webVR into VR Shell (Closed)
DescriptionVR: Content size incorrect when transitioning from webVR into VR Shell
The issue here is we are setting the virtual display's size when we
enter WebVR, but not when we exit it to VrShell. This means that
content is incorrectly sized.
The fix simply sets the virtual display's size when we exit WebVR to VrShell.
BUG=718578
Review-Url: https://codereview.chromium.org/2906173002
Cr-Commit-Position: refs/heads/master@{#476074}
Committed: https://chromium.googlesource.com/chromium/src/+/625bfbd862c294832d217c35245e7b61a1e6ccfb
Patch Set 1 #
Total comments: 2
Patch Set 2 : cr feedback #Messages
Total messages: 22 (13 generated)
Description was changed from ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to vrshell. This means that content is incorrectly sized. BUG=718578 ========== to ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to vrshell. This means that content is incorrectly sized. BUG=718578 ==========
billorr@chromium.org changed reviewers: + mthiesse@chromium.org
PTAL - This fixes the problem, but let me know if there is a better place for this to go, or a better approach. Thanks!
lgtm https://codereview.chromium.org/2906173002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java (right): https://codereview.chromium.org/2906173002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:492: DisplayAndroid primaryDisplay = DisplayAndroid.getNonMultiDisplay(mActivity); nit: Please share this logic with the other place that does this. Possibly a setWebVrDisplaySize() function?
https://codereview.chromium.org/2906173002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java (right): https://codereview.chromium.org/2906173002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:492: DisplayAndroid primaryDisplay = DisplayAndroid.getNonMultiDisplay(mActivity); On 2017/05/27 03:11:39, mthiesse wrote: > nit: Please share this logic with the other place that does this. Possibly a > setWebVrDisplaySize() function? Done.
The CQ bit was checked by billorr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by billorr@chromium.org
The CQ bit was checked by billorr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mthiesse@chromium.org Link to the patchset: https://codereview.chromium.org/2906173002/#ps20001 (title: "cr feedback")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
ddorwin@chromium.org changed reviewers: + ddorwin@chromium.org
Please update the description to describe what the patch does. As is, it sounds like it makes the size incorrect.
It should be pretty easy to add e2e tests to make sure this doesn't regress in the future. Feel free to submit without them, but if so, please file a bug to add them.
Description was changed from ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to vrshell. This means that content is incorrectly sized. BUG=718578 ========== to ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to VrShell. This means that content is incorrectly sized. The fix simply sets the virtual display's size when we exit WebVR to VrShell. BUG=718578 ==========
The CQ bit was checked by billorr@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496264731552380,
"parent_rev": "7299ee2d798ce960049fb63d41b01e624ebb11d4", "commit_rev":
"625bfbd862c294832d217c35245e7b61a1e6ccfb"}
Message was sent while issue was closed.
Description was changed from ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to VrShell. This means that content is incorrectly sized. The fix simply sets the virtual display's size when we exit WebVR to VrShell. BUG=718578 ========== to ========== VR: Content size incorrect when transitioning from webVR into VR Shell The issue here is we are setting the virtual display's size when we enter WebVR, but not when we exit it to VrShell. This means that content is incorrectly sized. The fix simply sets the virtual display's size when we exit WebVR to VrShell. BUG=718578 Review-Url: https://codereview.chromium.org/2906173002 Cr-Commit-Position: refs/heads/master@{#476074} Committed: https://chromium.googlesource.com/chromium/src/+/625bfbd862c294832d217c35245e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/625bfbd862c294832d217c35245e... |
