Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2906173002: VR: Content size incorrect when transitioning from webVR into VR Shell (Closed)
Patch Set: cr feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
index 8bcd63ca3e5200930bb463feb283c0ca15a8b292..9ed4e760e1319239f2763bcc777abbe444553b26 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
@@ -287,13 +287,7 @@ public class VrShellImpl
inCct, getGvrApi().getNativeGvrContext(), mReprojectedRendering);
// Set the UI and content sizes before we load the UI.
- if (forWebVr) {
- DisplayAndroid primaryDisplay = DisplayAndroid.getNonMultiDisplay(mActivity);
- setContentCssSize(
- primaryDisplay.getDisplayWidth(), primaryDisplay.getDisplayHeight(), WEBVR_DPR);
- } else {
- setContentCssSize(DEFAULT_CONTENT_WIDTH, DEFAULT_CONTENT_HEIGHT, DEFAULT_DPR);
- }
+ updateWebVrDisplaySize(forWebVr);
swapToForegroundTab();
createTabList();
@@ -487,6 +481,18 @@ public class VrShellImpl
public void setWebVrModeEnabled(boolean enabled) {
mContentVrWindowAndroid.setVSyncPaused(enabled);
nativeSetWebVrMode(mNativeVrShell, enabled);
+
+ updateWebVrDisplaySize(enabled);
+ }
+
+ private void updateWebVrDisplaySize(boolean inWebVr) {
+ if (inWebVr) {
+ DisplayAndroid primaryDisplay = DisplayAndroid.getNonMultiDisplay(mActivity);
+ setContentCssSize(
+ primaryDisplay.getDisplayWidth(), primaryDisplay.getDisplayHeight(), WEBVR_DPR);
+ } else {
+ setContentCssSize(DEFAULT_CONTENT_WIDTH, DEFAULT_CONTENT_HEIGHT, DEFAULT_DPR);
+ }
}
@Override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698