Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2905943002: [vpython] Incorporate interpreter path/hash. (Closed)

Created:
3 years, 7 months ago by dnj
Modified:
3 years, 6 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[vpython] Incorporate interpreter path/hash. VirtualEnv bakes the host Python interpreter's path into its configuration. This means that if the underlying interpreter changes or is replaced, "vpython" will continue using the old specification unquestioningly, potentially leading to some inconsistencies. This approach creates a new message, "Runtime", which represents the Python runtime configuration, including its interpreter hash. Runtime is folded into "vpython"'s environment hash, meaning that if the interpreter changes, "vpython" will assign the new interpreter to a different environment. BUG=None TEST=local Review-Url: https://codereview.chromium.org/2905943002 Committed: https://github.com/luci/luci-go/commit/6e3d45742db9d47fb9ab3b5f61f4dd6c0f532a1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -29 lines) Patch
M vpython/api/vpython/env.proto View 1 chunk +15 lines, -1 line 0 comments Download
vpython/api/vpython/env.pb.go View 5 chunks +64 lines, -13 lines 0 comments Download
M vpython/python/find.go View 1 chunk +5 lines, -1 line 0 comments Download
M vpython/python/interpreter.go View 3 chunks +56 lines, -0 lines 0 comments Download
M vpython/python/python_test.go View 1 chunk +8 lines, -0 lines 0 comments Download
M vpython/spec/spec.go View 2 chunks +14 lines, -7 lines 0 comments Download
M vpython/spec/spec_test.go View 2 chunks +3 lines, -2 lines 0 comments Download
M vpython/venv/config.go View 6 chunks +23 lines, -4 lines 0 comments Download
M vpython/venv/venv.go View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dnj
PTAL
3 years, 7 months ago (2017-05-25 21:39:08 UTC) #2
iannucci
lgtm
3 years, 7 months ago (2017-05-25 21:45:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905943002/1
3 years, 6 months ago (2017-05-26 19:54:26 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-26 20:05:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6e3d45742db9d47fb9ab3b5f61f4dd6c0f532a1d

Powered by Google App Engine
This is Rietveld 408576698